Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Improve icons display #18520

Merged
merged 1 commit into from
Nov 25, 2019
Merged

[Autocomplete] Improve icons display #18520

merged 1 commit into from
Nov 25, 2019

Conversation

oliviertassinari
Copy link
Member

Closes #18463
Closes #18460

@oliviertassinari oliviertassinari added new feature New feature or request component: autocomplete This is the name of the generic UI component, not the React module! labels Nov 23, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 23, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 75697b3...f0593dd

bundle Size Change Size Gzip Change Gzip
Autocomplete ▲ +269 B (+0.21% ) 126 kB ▲ +82 B (+0.21% ) 40.1 kB
@material-ui/lab ▲ +269 B (+0.16% ) 172 kB ▲ +63 B (+0.12% ) 52 kB
@material-ui/core[umd] ▼ -148 B (-0.05% ) 310 kB ▼ -42 B (-0.05% ) 89.3 kB
TextField ▼ -144 B (-0.12% ) 121 kB ▼ -43 B (-0.12% ) 35.5 kB
@material-ui/core ▼ -144 B (-0.04% ) 351 kB ▼ -35 B (-0.04% ) 96.1 kB
Select ▼ -144 B (-0.13% ) 113 kB ▼ -32 B (-0.10% ) 33.5 kB
TablePagination ▼ -144 B (-0.10% ) 139 kB ▼ -26 B (-0.06% ) 40.7 kB
FilledInput ▼ -117 B (-0.16% ) 72.1 kB ▼ -39 B (-0.17% ) 22.3 kB
OutlinedInput ▼ -117 B (-0.16% ) 72.5 kB ▼ -36 B (-0.16% ) 22.5 kB
Input ▼ -87 B (-0.12% ) 71 kB ▼ -42 B (-0.19% ) 22.1 kB
InputBase ▼ -87 B (-0.13% ) 69.1 kB ▼ -40 B (-0.18% ) 21.6 kB
NativeSelect ▼ -74 B (-0.10% ) 75.3 kB ▼ -28 B (-0.12% ) 23.7 kB
@material-ui/styles -- 50.8 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.06 kB
AppBar -- 62.4 kB -- 19.5 kB
Avatar -- 61.4 kB -- 19.3 kB
Backdrop -- 66.4 kB -- 20.5 kB
Badge -- 64 kB -- 19.8 kB
BottomNavigation -- 61 kB -- 19.1 kB
BottomNavigationAction -- 74 kB -- 23.4 kB
Box -- 69.4 kB -- 21 kB
Breadcrumbs -- 66.6 kB -- 20.9 kB
Button -- 78 kB -- 23.8 kB
ButtonBase -- 72.5 kB -- 22.7 kB
ButtonGroup -- 80.6 kB -- 24.7 kB
Card -- 61.3 kB -- 19.2 kB
CardActionArea -- 73.6 kB -- 23.2 kB
CardActions -- 60.7 kB -- 19 kB
CardContent -- 60.6 kB -- 18.9 kB
CardHeader -- 63.7 kB -- 20 kB
CardMedia -- 61 kB -- 19.1 kB
Checkbox -- 80.4 kB -- 25.2 kB
Chip -- 81.1 kB -- 24.8 kB
CircularProgress -- 62.7 kB -- 19.7 kB
ClickAwayListener -- 3.87 kB -- 1.56 kB
Collapse -- 66.5 kB -- 20.5 kB
colorManipulator -- 3.83 kB -- 1.52 kB
Container -- 61.8 kB -- 19.3 kB
CssBaseline -- 56.2 kB -- 17.6 kB
Dialog -- 81.2 kB -- 25.2 kB
DialogActions -- 60.7 kB -- 19 kB
DialogContent -- 60.8 kB -- 19.1 kB
DialogContentText -- 62.7 kB -- 19.7 kB
DialogTitle -- 62.9 kB -- 19.8 kB
Divider -- 61.2 kB -- 19.2 kB
docs.landing -- 55.5 kB -- 14.4 kB
docs.main -- 609 kB -- 194 kB
Drawer -- 82.9 kB -- 25.7 kB
ExpansionPanel -- 69.9 kB -- 21.8 kB
ExpansionPanelActions -- 60.7 kB -- 19 kB
ExpansionPanelDetails -- 60.6 kB -- 18.9 kB
ExpansionPanelSummary -- 76.7 kB -- 24.1 kB
Fab -- 75.4 kB -- 23.4 kB
Fade -- 22.2 kB -- 7.66 kB
FormControl -- 63 kB -- 19.5 kB
FormControlLabel -- 64.1 kB -- 20.1 kB
FormGroup -- 60.6 kB -- 19 kB
FormHelperText -- 61.9 kB -- 19.4 kB
FormLabel -- 62.1 kB -- 19.2 kB
Grid -- 63.7 kB -- 20 kB
GridList -- 61.1 kB -- 19.2 kB
GridListTile -- 62.3 kB -- 19.5 kB
GridListTileBar -- 61.8 kB -- 19.4 kB
Grow -- 22.8 kB -- 7.79 kB
Hidden -- 64.5 kB -- 20.2 kB
Icon -- 61.4 kB -- 19.2 kB
IconButton -- 74.7 kB -- 23.2 kB
InputAdornment -- 63.7 kB -- 20.1 kB
InputLabel -- 63.9 kB -- 19.9 kB
LinearProgress -- 64 kB -- 19.9 kB
Link -- 65.2 kB -- 20.7 kB
List -- 61 kB -- 18.9 kB
ListItem -- 75.7 kB -- 23.6 kB
ListItemAvatar -- 60.7 kB -- 19 kB
ListItemIcon -- 60.8 kB -- 19 kB
ListItemSecondaryAction -- 60.6 kB -- 19 kB
ListItemText -- 63.6 kB -- 20 kB
ListSubheader -- 61.4 kB -- 19.3 kB
Menu -- 86.9 kB -- 27.3 kB
MenuItem -- 76.7 kB -- 23.9 kB
MenuList -- 64.6 kB -- 20.1 kB
MobileStepper -- 66.3 kB -- 20.7 kB
Modal -- 14.2 kB -- 4.98 kB
NoSsr -- 2.19 kB -- 1.03 kB
Paper -- 60.9 kB -- 18.9 kB
Popover -- 81.2 kB -- 25.1 kB
Popper -- 28.6 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 81.2 kB -- 25.5 kB
RadioGroup -- 61.8 kB -- 19.3 kB
Rating -- 68.6 kB -- 22 kB
RootRef -- 4.43 kB -- 1.67 kB
Skeleton -- 61.2 kB -- 19.3 kB
Slide -- 24.3 kB -- 8.27 kB
Slider -- 74.2 kB -- 23.4 kB
Snackbar -- 75.7 kB -- 23.6 kB
SnackbarContent -- 64.3 kB -- 20.2 kB
SpeedDial -- 84.6 kB -- 26.6 kB
SpeedDialAction -- 115 kB -- 36.4 kB
SpeedDialIcon -- 63.2 kB -- 19.8 kB
Step -- 61.2 kB -- 19.2 kB
StepButton -- 80.9 kB -- 25.4 kB
StepConnector -- 61.3 kB -- 19.3 kB
StepContent -- 67.6 kB -- 21.1 kB
StepIcon -- 63.3 kB -- 19.7 kB
StepLabel -- 67.2 kB -- 21.1 kB
Stepper -- 63.4 kB -- 19.9 kB
styles/createMuiTheme -- 15.4 kB -- 5.43 kB
SvgIcon -- 61.7 kB -- 19.2 kB
SwipeableDrawer -- 90.3 kB -- 28.1 kB
Switch -- 79.7 kB -- 24.8 kB
Tab -- 74.9 kB -- 23.7 kB
Table -- 61.2 kB -- 19.2 kB
TableBody -- 60.7 kB -- 19 kB
TableCell -- 62.7 kB -- 19.7 kB
TableFooter -- 60.7 kB -- 19 kB
TableHead -- 60.7 kB -- 19 kB
TableRow -- 61.1 kB -- 19.1 kB
TableSortLabel -- 75.9 kB -- 24 kB
Tabs -- 84 kB -- 26.8 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
ToggleButton -- 74.7 kB -- 23.6 kB
ToggleButtonGroup -- 61.8 kB -- 19.4 kB
Toolbar -- 60.9 kB -- 19.1 kB
Tooltip -- 99.1 kB -- 31.4 kB
TreeItem -- 72.2 kB -- 22.7 kB
TreeView -- 65 kB -- 20.3 kB
Typography -- 62.3 kB -- 19.4 kB
useAutocomplete -- 12.3 kB -- 4.54 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
Zoom -- 22.3 kB -- 7.67 kB

Generated by 🚫 dangerJS against f0593dd

@oliviertassinari oliviertassinari merged commit f6a9ea1 into mui:master Nov 25, 2019
@oliviertassinari oliviertassinari deleted the autocomplete-improve-icons-display branch November 25, 2019 08:47
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 25, 2019
@eps1lon
add changeset for mui#18520
254370a
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 25, 2019
@eps1lon
add changeset for mui#18520
febb62e
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 25, 2019
@eps1lon
add changeset for mui#18520
af5c8e1
@oliviertassinari oliviertassinari mentioned this pull request Nov 27, 2019
Closed
@eddiemonge
Copy link
Contributor

This broke my implementation. I don't know if it breaks others as well.

Also, is the selector supposed to be && and not &?

image

@oliviertassinari oliviertassinari mentioned this pull request Dec 10, 2019
Closed
2 tasks
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
@oliviertassinari oliviertassinari mentioned this pull request Jan 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@oliviertassinari @mui-pr-bot @eddiemonge