Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions don't work #1627

Closed
oliviertassinari opened this issue Apr 6, 2020 · 7 comments · Fixed by #1634
Closed

Installation instructions don't work #1627

oliviertassinari opened this issue Apr 6, 2020 · 7 comments · Fixed by #1634
Labels
bug 🐛 Something isn't working
Milestone

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 6, 2020

The documentation encourages the usage of:

// pick a date util library
import DateFnsUtils from '@material-ui-pickers/adapter/date-fns';

Unfortunately, it doesn't seem to work: https://codesandbox.io/s/ecstatic-solomon-v4gvv.

Environment

Tech Version
@material-ui/pickers v4.0.0-alpha.5
@dmtrKovalenko
Copy link
Member

dmtrKovalenko commented Apr 6, 2020

Haha typo -> @material-ui/pickers/adapter/date-fns
@material-ui[/]pickers

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Apr 6, 2020

A good one to fix 😆 but it might not be enough.
The reproduction uses @material-ui/pickers/adapter/date-fns.

@dmtrKovalenko
Copy link
Member

Oh god, I forgot to fix this before release

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Apr 9, 2020

@dmtrKovalenko I think that it's fine, it's an alpha anyway. I think that we should more aim on making releases on a fixed schedule than aiming for releasing a specific set of changes :).

@mifrej
Copy link

mifrej commented May 5, 2020

Could we please release next alpha with this.

@oliviertassinari
Copy link
Member Author

@mifrej a new alpha version has been release with the changes.

@mifrej
Copy link

mifrej commented May 7, 2020

Already on it! Keep the great work! Thanks

@oliviertassinari oliviertassinari modified the milestones: v4, v5 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants