From b3cd78382eff41d194ee6dc516a83bab4790bdc4 Mon Sep 17 00:00:00 2001 From: Rostislav Bobrovsky Date: Thu, 23 Jan 2020 13:00:15 +0200 Subject: [PATCH] [Checkbox][Radio] Fix describeConformance by adding after callback --- packages/material-ui/src/Checkbox/Checkbox.test.js | 12 +++--------- packages/material-ui/src/Radio/Radio.test.js | 12 +++--------- 2 files changed, 6 insertions(+), 18 deletions(-) diff --git a/packages/material-ui/src/Checkbox/Checkbox.test.js b/packages/material-ui/src/Checkbox/Checkbox.test.js index 100eac53ab76b6..313514d7f3d4eb 100644 --- a/packages/material-ui/src/Checkbox/Checkbox.test.js +++ b/packages/material-ui/src/Checkbox/Checkbox.test.js @@ -5,6 +5,7 @@ import describeConformance from '../test-utils/describeConformance'; import { createClientRender } from 'test/utils/createClientRender'; import Checkbox from './Checkbox'; import FormControl from '../FormControl'; +import IconButton from '../IconButton'; describe('', () => { const render = createClientRender(); @@ -16,21 +17,14 @@ describe('', () => { mount = createMount({ strict: true }); }); - describeConformance(, () => ({ - mount, - only: ['refForwarding'], - refInstanceof: window.HTMLSpanElement, - after: () => mount.cleanUp(), - })); - - /* TODO Checkbox violates root component describeConformance(, () => ({ classes, inheritComponent: IconButton, mount, refInstanceof: window.HTMLSpanElement, skip: ['componentProp'], - })); */ + after: () => mount.cleanUp(), + })); it('should have the classes required for Checkbox', () => { assert.strictEqual(typeof classes.root, 'string'); diff --git a/packages/material-ui/src/Radio/Radio.test.js b/packages/material-ui/src/Radio/Radio.test.js index 0ac9654174e90a..102bab4e9aa874 100644 --- a/packages/material-ui/src/Radio/Radio.test.js +++ b/packages/material-ui/src/Radio/Radio.test.js @@ -4,6 +4,7 @@ import { getClasses, createMount } from '@material-ui/core/test-utils'; import describeConformance from '@material-ui/core/test-utils/describeConformance'; import { createClientRender } from 'test/utils/createClientRender'; import FormControl from '../FormControl'; +import IconButton from '../IconButton'; import Radio from './Radio'; describe('', () => { @@ -16,21 +17,14 @@ describe('', () => { mount = createMount({ strict: true }); }); - describeConformance(, () => ({ - mount, - only: ['refForwarding'], - refInstanceof: window.HTMLSpanElement, - after: () => mount.cleanUp(), - })); - - /* TODO Radio violates root component describeConformance(, () => ({ classes, inheritComponent: IconButton, mount, refInstanceof: window.HTMLSpanElement, skip: ['componentProp'], - })); */ + after: () => mount.cleanUp(), + })); describe('styleSheet', () => { it('should have the classes required for SwitchBase', () => {