Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormLabel] [FormHelperText] classes keys #12363

Closed
Mangatt opened this issue Aug 1, 2018 · 3 comments
Closed

[FormLabel] [FormHelperText] classes keys #12363

Mangatt opened this issue Aug 1, 2018 · 3 comments
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@Mangatt
Copy link
Contributor

Mangatt commented Aug 1, 2018

Even though [FormControl] provides context filled/focused/error/required, not all these keys are available in [FormLabel] and [FormHelperText] classes.

I believe that filled/focused/required keys should be available as well. It is valid use case to change Component styling based on it's internal state.

I know that it is possible to achieve similar functionality now (hijack MuiFormControl context or control Component state externally), but it's bit overkill since it's already been done once.

@oliviertassinari
Copy link
Member

@Mangatt Would having #7633 solve your problem and remove the need for adding these extra classes?

@Mangatt
Copy link
Contributor Author

Mangatt commented Aug 1, 2018

Probably. But I still think that it should be available directly through classes prop, there's no reason to omit those keys.

@oliviertassinari oliviertassinari added new feature New feature or request good first issue Great for first contributions. Enable to learn the contribution process. labels Aug 1, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 1, 2018

@Mangatt I agree, feel free to work on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants