Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select still can not use boolean value #12517

Closed
2 tasks done
palaniichukdmytro opened this issue Aug 14, 2018 · 4 comments
Closed
2 tasks done

Select still can not use boolean value #12517

palaniichukdmytro opened this issue Aug 14, 2018 · 4 comments
Assignees
@oliviertassinari
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!

Comments

@palaniichukdmytro
Copy link
Contributor

palaniichukdmytro commented Aug 14, 2018 •
edited
Loading

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

boolean value should be accept correct to Select

Current Behavior

Warning: Failed prop type: Invalid prop valuesupplied toInput.
Looks like in 1.5.0 was fixed
and discussed here
#10845 (comment)

Steps to Reproduce

Link: https://codesandbox.io/s/ym1o3189y9

Your Environment

Tech Version
Material-UI v1.5.0
React 16. 4.0
browser Chrome
etc.
@palaniichukdmytro
Copy link
Contributor Author

Probably better update Input also

@RavenHursT
Copy link

Agreed. Just spent an hour or two scratching my head on this. Guess for now I'm gonna have to do some kind of true ==0 1 / false === 0 translation or something...

@oliviertassinari oliviertassinari self-assigned this Aug 14, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! labels Aug 14, 2018
@oliviertassinari oliviertassinari mentioned this issue Aug 14, 2018
Merged
@RavenHursT
Copy link

Just for clarity... You'll still need to translate the boolean input on the way out from a string (event.target.value will be "true" or "false")...

#12522 (comment)

@oliviertassinari
Copy link
Member

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RavenHursT @oliviertassinari @palaniichukdmytro