Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Icon does not match specification? #15055

Closed
2 tasks done
raymondsze opened this issue Mar 26, 2019 · 4 comments
Closed
2 tasks done

Select Icon does not match specification? #15055

raymondsze opened this issue Mar 26, 2019 · 4 comments
Labels
component: select This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@raymondsze
Copy link
Contributor

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

The dropdown icon should transform to dropup icon (also highlighted with primary color) when the select field is focused.
https://material.io/design/components/menus.html#exposed-dropdown-menu

Current Behavior 😯

The dropdown icon is still dropdown icon when the select field is focused.

Steps to Reproduce 🕹

Link:

Context 🔦

Your Environment 🌎

Tech Version
Material-UI v3.?.?
React
Browser
TypeScript
etc.
@eps1lon eps1lon added design: material This is about Material Design, please involve a visual or UX designer in the process status: waiting for author Issue with insufficient information labels Mar 26, 2019
@eps1lon
Copy link
Member

eps1lon commented Mar 26, 2019

Could you be a bit more specific about the component or demo that has this issue?

@oliviertassinari
Copy link
Member

It's related to #9893 and #10804.

@raymondsze
Copy link
Contributor Author

Could you be a bit more specific about the component or demo that has this issue?

  1. When the Menu is not popped-up, it show the dropdown (downward triangle) icon. When the Menu is popped-up, the dropdown icon should rotated 180 degrees (upward triangle).

  2. The dropdown menu should located under the dropdown button with 0 pixel between the bottom of button and the menu if space allowed.

  3. filled Select should have zero border top radius.

Also, I found that the material design guideline seems mark the checkbox and radio button with primary color now. Should primary color be the default color in MuiTheme for checkbox, radio and switch?

@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! and removed status: waiting for author Issue with insufficient information labels Mar 28, 2019
@ryancogswell ryancogswell mentioned this issue May 6, 2019
Open
1 task
@oliviertassinari oliviertassinari changed the title Dropdown Icon does not match specification? Select Icon does not match specification? Nov 23, 2019
@oliviertassinari oliviertassinari mentioned this issue Nov 23, 2019
Closed
2 tasks
@oliviertassinari
Copy link
Member

The icon transform effect was recently implemented #17037. I have tried the icon color change but give up on it to keep the overrides simple. I think that we can close, at least for #18493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @eps1lon @raymondsze