Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Component align property's Bug in Edge Browser #17922

Closed
2 tasks done
AliYmn opened this issue Oct 17, 2019 · 8 comments
Closed
2 tasks done

Container Component align property's Bug in Edge Browser #17922

AliYmn opened this issue Oct 17, 2019 · 8 comments
Labels
support: Stack Overflow Please ask the community on Stack Overflow

Comments

@AliYmn
Copy link

AliYmn commented Oct 17, 2019

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Container is good work good like demo on chrome (https://material-ui.com/components/container/)

Expected Behavior 🤔

my Container component's align="center" doesn't work in edge browser, like this;

<Container
          align="center"
          component="main"
          fixed
>

Your Environment 🌎

Tech Version
Material-UI v4.5.1
React ^16.10.2
Browser Edge
TypeScript no
@oliviertassinari oliviertassinari added the support: Stack Overflow Please ask the community on Stack Overflow label Oct 17, 2019
@support
Copy link

support bot commented Oct 17, 2019

👋 Thanks for using Material-UI!

We use GitHub issues exclusively as a bug and feature requests tracker, however,
this issue appears to be a support request.

For support, please check out https://material-ui.com/getting-started/support/. Thanks!

If you have a question on StackOverflow, you are welcome to link to it here, it might help others.
If your issue is subsequently confirmed as a bug, and the report follows the issue template, it can be reopened.

@support support bot closed this as completed Oct 17, 2019
@AliYmn
Copy link
Author

AliYmn commented Oct 25, 2019

@oliviertassinari can you check again? Thank you.

@oliviertassinari
Copy link
Member

@AliYmn Do you have a reproduction?

@AliYmn
Copy link
Author

AliYmn commented Oct 26, 2019

@oliviertassinari firstly thank you for respond. I can show it.

on chrome ( align="center" is working.)

on edge ( align="center" doesn't work)

note : i think same problem in grid

@oliviertassinari
Copy link
Member

Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point.

@AliYmn
Copy link
Author

AliYmn commented Oct 29, 2019

@oliviertassinari i tryed in this web site than i finded my problem.

you can see it : https://codesandbox.io/s/create-react-app-8hgzb

--> This not working with component="main" on edge browser

<Container component="main" align="center">
      <Box my={4}>
        <Typography variant="h4" component="h1" gutterBottom>
          Create React App v4-beta example
        </Typography>
        <ProTip />
        <Copyright />
      </Box>
    </Container>

when i delete component="main" this page centered all browser :)) is this normal?


on chrome browser ;

on edge browser;

@oliviertassinari
Copy link
Member

@AliYmn This was definitely a StackOverflow question (tip: align="center" is not a Container prop, after #15561, textAlign="center" will work). It seems that edge and chrome have different behaviors for the native align prop.

@AliYmn
Copy link
Author

AliYmn commented Oct 30, 2019

Thank you for all. Now i use it without component="main".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: Stack Overflow Please ask the community on Stack Overflow
Projects
None yet
Development

No branches or pull requests

2 participants