Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do away with SelectField#selectedIndex in favor of value #2554

Closed
ajsharp opened this issue Dec 16, 2015 · 3 comments
Closed

Do away with SelectField#selectedIndex in favor of value #2554

ajsharp opened this issue Dec 16, 2015 · 3 comments
Labels
new feature New feature or request
Milestone
0.14.0 Release

Comments

@ajsharp
Copy link

ajsharp commented Dec 16, 2015

To specify the currently selected item, you should be able to do it by specifying a value property, in staying with convention of most other form components.
@alitaheri
Copy link
Member

yup that sounds like a great idea! We are going to make SelectField composable. It would be awesome if we fixed this, too. Actually I'm working on it at the moment, i'll try to see if I can squeeze this in without breaking anything.

@oliviertassinari
Copy link
Member

Actually I'm working on it at the moment

Awesome, I was planning to work on this (to fix my selenium tests), please go ahead 👍

@alitaheri
Copy link
Member

@oliviertassinari Yeah I'll make a PR as soon as I hit some stability.

@alitaheri alitaheri added the new feature New feature or request label Dec 16, 2015
@alitaheri alitaheri added this to the 0.14.0 Release milestone Dec 16, 2015
@alitaheri alitaheri mentioned this issue Dec 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
0.14.0 Release
Development

No branches or pull requests
3 participants
@ajsharp @oliviertassinari @alitaheri