Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the css to css in js #290

Closed
cuongcua90 opened this issue Jan 30, 2015 · 1 comment
Closed

Port the css to css in js #290

cuongcua90 opened this issue Jan 30, 2015 · 1 comment
Labels
customization: css Design CSS customizability customization: theme Centered around the theming features

Comments

@cuongcua90
Copy link
Contributor

Hi material ui,

I create this issue to discuss about the way to port this repository styles to css in js. My team has used this repository and the css in js in my project also. I know, we have some discussion in the gitter chat about this problem. And the problem that @hai-cea concern is the way to make the theme configure. I think there are some straightforward way, but it is not much convenience now.

  1. First, we can expose for example defineTheme() and reset the global style in material ui.
  2. The other way, we can transform the styles props to the component and have mixin to process with the component styles.

Hope we have good solution for this.

@hai-cea
Copy link
Member

hai-cea commented Jan 30, 2015

Thanks @cuongcua90 - Let's move this discussion to #30

@hai-cea hai-cea closed this as completed Jan 30, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added customization: theme Centered around the theming features customization: css Design CSS customizability and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: css Design CSS customizability customization: theme Centered around the theming features
Projects
None yet
Development

No branches or pull requests

4 participants