Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Replace <DocSearch> for in-house implementation #37599

Open
pantelispanayiotou opened this issue Jun 15, 2023 · 1 comment
Open
Assignees
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product

Comments

@pantelispanayiotou
Copy link

pantelispanayiotou commented Jun 15, 2023

Related page

https://mui.com

Kind of issue

Missing information

Issue description

I was looking for how the algolia search is implemented on the homepage. As i can see it doesn't use any mui components, except for the hits that typography and badges are used. Is there any specific reasons on why this is not implemented using the mui's Autocomplete component?

Context 🔦

We need to implement algolia in our site and thinking of how we can do this using material ui. The first option is to build it without the components that are provided from algolia (instantsearch) so that we can leverage the mui components.

@pantelispanayiotou pantelispanayiotou added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jun 15, 2023
@zannager zannager added the component: autocomplete This is the name of the generic UI component, not the React module! label Jun 15, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 15, 2023

How is Algolia search implemented on the home page of MUI?

@pantelispanayiotou It's implemented here:

export default function AppSearch(props) {

Is there any specific reasons on why this is not implemented using the mui's Autocomplete component?

We talked about using the Material UI component for it during the implementation but we went with the Algolia UI library to save time. It's definitely in our plan to replace the UX with Material UI components.

See #16502 under:

What Algolia did with DocSearch could be much better, I think this is what we should use this GitHub issue for.

We need to implement algolia in our site and thinking of how we can do this using material UI.

Yes, then have a look at mui/mui-x#13932. It's part of the problem we are trying to solve.

@DavidCnoops DavidCnoops removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 16, 2023
@samuelsycamore samuelsycamore added the support: question Community support but can be turned into an improvement label Jul 2, 2023
@mj12albert mj12albert removed the component: autocomplete This is the name of the generic UI component, not the React module! label Nov 22, 2023
@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product and removed support: question Community support but can be turned into an improvement support: docs-feedback Feedback from documentation page labels Feb 3, 2024
@oliviertassinari oliviertassinari changed the title [docs] how is algolia search implemented on the home page of mui [docs] Replace <DocSearch> for in-house implementation Feb 3, 2024
@oliviertassinari oliviertassinari changed the title [docs] Replace <DocSearch> for in-house implementation [docs-infra] Replace <DocSearch> for in-house implementation Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

No branches or pull requests

8 participants