Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Isolate error messages, e.g. MUI -> Material UI #40590

Open
oliviertassinari opened this issue Jan 15, 2024 · 0 comments
Open

[docs] Isolate error messages, e.g. MUI -> Material UI #40590

oliviertassinari opened this issue Jan 15, 2024 · 0 comments
Assignees
Labels
docs Improvements or additions to the documentation dx Related to developers' experience enhancement This is not a bug, nor a new feature

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 15, 2024

Steps to reproduce

We prefix all the errors with MUI: but we shouldn't, we should use the project name instead.

Current behavior

This error is about MUI System, it's not about MUI

if (!themeValue) {
console.warn(
`MUI: Value for key: ${val} does not exist in "theme.${propertyThemeKey}" or "theme.vars.${propertyThemeKey}"`,
);

Expected behavior

 if (!themeValue) { 
   console.warn( 
     `MUI System: Value for key: ${val} does not exist in "theme.${propertyThemeKey}" or "theme.vars.${propertyThemeKey}"`, 
   ); 

Context

This is a continuation of mui/mui-x#11645.

For the back story, we are moving toward forcing developers to import from @mui/base, @mui/system, and @mui/material directly (no longer reexporting anything from @mui/material). This is a strategic move to:

  • better isolate the responsibilities, to educate developers that each of these 3 modules solves different problems
  • better isolate the bundle size, removing the perception of bloat
  • better support the progressive adoption of the MUI stack
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature labels Jan 15, 2024
@oliviertassinari oliviertassinari added the dx Related to developers' experience label Jan 15, 2024
@brijeshb42 brijeshb42 self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation dx Related to developers' experience enhancement This is not a bug, nor a new feature
Projects
None yet
Development

No branches or pull requests

2 participants