Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Snackbar] Stop recommending the usage of notistack, the library is seemingly no longer (properly) maintained #42615

Open
favna opened this issue Jun 11, 2024 · 2 comments
Assignees
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material support: docs-feedback Feedback from documentation page

Comments

@favna
Copy link
Contributor

favna commented Jun 11, 2024

Related page

https://mui.com/material-ui/react-snackbar/

Kind of issue

Other

Issue description

The current documentation page for react-snackbar mentions notistack for third-party integrations. However, the author of the notistack seems to have gone MIA with an ever-piling stack of unaddressed issues and PRs. I also created an issue querying if the project is still maintained, which thus far has gone unanswered: iamhosseindhv/notistack#602.

It would be best for MUI to stop directing people to use an unmaintained library as that is asking for trouble sooner or later.

Context

Notistack should be removed from third-party integrations on the relevant page, and the whole block should be removed as it is the last one remaining. Possibly the documentation could link to contemporary projects such as react-toastify. A project like react-toastify does not use MUI, but it is a good alternative to achieve stateful imperative snackbar API.

Search keywords: notistack, snackbar

@favna favna added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jun 11, 2024
@zannager zannager added the component: snackbar This is the name of the generic UI component, not the React module! label Jun 11, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [Snackbar][docs] Stop recommending the usage of notistack, the library is seemingly no longer (properly) maintained [docs][Snackbar] Stop recommending the usage of notistack, the library is seemingly no longer (properly) maintained Jun 24, 2024
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Jun 24, 2024

I agree. We shouldn't recommend this library in our documentation. I've opened PR #42739 to remove it.

Originally, we added Material UI's Snackbar usage with notistack to show vertically stacked Snackbars. I was working on implementing this feature directly in Material UI (see PR #31991), but the PR was halted for various reasons.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 24, 2024
@DiegoAndai DiegoAndai added this to the Material UI with Base UI milestone Jul 2, 2024
@DiegoAndai
Copy link
Member

I added this issue to the Material UI with the Base UI milestone, as we should ideally rely on Base UI's Toast component, which will eventually be released. I expect us to work on this during Q4.

@oliviertassinari oliviertassinari removed this from the Material UI with Base UI milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material support: docs-feedback Feedback from documentation page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants