Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Fix memoTheme() source location #43440

Closed
oliviertassinari opened this issue Aug 26, 2024 · 1 comment · Fixed by #43412
Closed

[system] Fix memoTheme() source location #43440

oliviertassinari opened this issue Aug 26, 2024 · 1 comment · Fixed by #43412
Assignees
Labels
package: styled-engine Specific to @mui/styled-engine package: system Specific to @mui/system v6.x

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 26, 2024

Steps to reproduce

export default function memoTheme(styleFn: ThemeStyleFunction) {

Current behavior

The helper is located in @mui/material source.

Expected behavior

This helper should be owned by @mui/styled-engine or at the very least @mui/system.

Context

Introduced in #43372. I would expect this helper to be used by anyone extending MUI System. Material UI, MUI X, Joy UI, etc.

It's part of #40594, its umbrella issue.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@oliviertassinari oliviertassinari added package: system Specific to @mui/system status: waiting for maintainer These issues haven't been looked at yet by a maintainer package: styled-engine Specific to @mui/styled-engine labels Aug 26, 2024
@oliviertassinari oliviertassinari changed the title [system] Fix memoTheme location [system] Fix memoTheme() source location Aug 26, 2024
@siriwatknp siriwatknp added v6.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 28, 2024
Copy link

github-actions bot commented Oct 2, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styled-engine Specific to @mui/styled-engine package: system Specific to @mui/system v6.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@oliviertassinari @mnajdova @siriwatknp and others