Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectField] Port component #5716

Closed
5 tasks
oliviertassinari opened this issue Dec 4, 2016 · 20 comments
Closed
5 tasks

[SelectField] Port component #5716

oliviertassinari opened this issue Dec 4, 2016 · 20 comments
Assignees
Labels
component: select This is the name of the generic UI component, not the React module!

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 4, 2016

I have gathered some though around things we could implement: #4891 (comment).

@oliviertassinari oliviertassinari added this to the next milestone Dec 4, 2016
@oliviertassinari oliviertassinari added the component: select This is the name of the generic UI component, not the React module! label Dec 18, 2016
@kybarg kybarg mentioned this issue Mar 8, 2017
11 tasks
@Shahrukh-Zindani Shahrukh-Zindani self-assigned this Mar 16, 2017
@damianobarbati
Copy link

Any news on this? When will SelectField make it into next alpha? :)

@jcheroske
Copy link

Not nagging, but this would be awesome to get in @next

@dcworldwide
Copy link

I reviewed my codebase, I could switch to next if this component was available. Hopefully someone smart from the community with some spare time can help us out :)

@damianobarbati
Copy link

@dcworldwide me too on about 6 projects, ready to move if @next gets a boost in development xD
I'd really like to contribute but I'm far from being able to do it.

@chyyran
Copy link

chyyran commented Jun 17, 2017

I'm building my app from ground up using @next so I'm waiting on SelectField, for now I'm using an html <select> until then.

@tkostus
Copy link

tkostus commented Jun 18, 2017

The way I worked around this (not only some components are missing in 1.x but I have also had issues with components in 0.x branch) was building material-ui 0.x locally and publishing to npm under a new name. I then npm install'ed it beside material-ui@next. Best of both worlds (if you can swallow increased bundle size...) :)

This of course allows you to mix and match components from 0.x and 1.x - so you get not only Select Field but all other components that are not yet ported and can switch to 1.x where useful (e.g. Table component which is awesome in 1.x).

Nonetheless, can't wait for SelectField in next!

@justinmasse
Copy link

justinmasse commented Jun 19, 2017

I'm also having this issue @tkostus. Any chance you can share the npm module you created?

Really tricky situation because the software we're developing right now needs the updated, however missing so many components is also problematic...

@tkostus
Copy link

tkostus commented Jun 20, 2017

Ya sure, I called it material-ui-effco. Version I based it off was 0.17.3; I didn't have a reason to update it so far. Hopefully this will do the job for you. If you need more recent version I can rebuild it.

This is probably obvious, but just to avoid potential confusion: you will need to wrap your topmost component in MuiThemeProvider twice - once for each package.

@npramod
Copy link

npramod commented Jul 7, 2017

@tkostus - Thanks for the workaround!

@oliviertassinari
Copy link
Member Author

@justinmasse If you are using yarn, you can simply alias the two versions.

@swerky
Copy link

swerky commented Aug 7, 2017

Hi, any news of a DropDownMenu or a SelectField ?

@the-simian
Copy link

@swerky I am working on a basic component right now: #7678

@vladimirpekez
Copy link

Our team is using v1 beta and we really miss selectfield - I guess v1 adoption will skyrocket after selectfield and date/time pickers ports are merged. Even breaking changes afterwards are fine :)

@damianobarbati
Copy link

+1

@Sharlaan
Copy link

Here a basic SelectField implementation, 100% composed with Material-UI v1 components (TextField, Menu & MenuItem)

But i feel these base components are quite limited in terms of functionality customisation. For example:

  • TextField can't accept anything but string, so forget about displaying Chips ...
  • i didnot find how to add a checkbox on MenuItem while keeping the "selected" functionality

@kybarg
Copy link
Contributor

kybarg commented Aug 18, 2017

@Sharlaan Here is select input implementation #6301

@Sharlaan
Copy link

Sharlaan commented Aug 18, 2017

@kybarg this one is closed, and @dummerbd seemed to want to wrap a native select html5 component, which extremely limited for customisation imho.

Maybe did you meant this thread #7632 ?
Sounds great work so far, but (didnot tested) i'm wondering if this implementation is flexible enough to manage ANYTHING as children (ie Chips or complex composiitons), or also custom selectionsRenderer for multiple selections with custom elements instead of plain boring value text(s) ?

@5angel
Copy link

5angel commented Aug 25, 2017

Subscribing to this thread, selectField is the only piece I need to migrate projects to v1

@oallouch
Copy link

My heart was beating when I saw the beta 7 was out.
Maybe next time :)

@sabatsu
Copy link

sabatsu commented Sep 1, 2017

+1
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests