Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] not working on some iPhones/versions of iOS #6558

Closed
Taakn opened this issue Apr 9, 2017 · 5 comments
Closed

[Autocomplete] not working on some iPhones/versions of iOS #6558

Taakn opened this issue Apr 9, 2017 · 5 comments
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@Taakn
Copy link

Taakn commented Apr 9, 2017

Problem description

Autocomplete dropdown does not appear on some versions of iOS + Safari. We've tested on multiple iPhone/iOS versions and bug is inconsistent. Bug does not appear with iOS emulators but it has appeared on iPhone 6+ and 6s devices. We've tested on multiple versions of Material-UI and it has appeared on 0.16.7 and up.

Link to minimal working code that reproduces the issue

Bug appears with the sample code on the documentation website

Versions

  • Material-UI: 0.16.7 and up
  • React:
  • Browser: Safari 10
@mbrookes
Copy link
Member

mbrookes commented Apr 9, 2017

@Taakn I can't see anything obvious in the 0.16.7 release notes that would impact this: https://github.com/callemall/material-ui/releases/tag/v0.16.7

git bisect around that release may be the way to go.

@Taakn Taakn changed the title Autocomplete not working on some iPhones/versions of iOS [Autocomplete] not working on some iPhones/versions of iOS Apr 11, 2017
@Taakn
Copy link
Author

Taakn commented Apr 11, 2017

So I went through some extensive testing to try and figure out exactly what versions of iOS or iPhones were affected. Here are my findings:

I went to an Apple Store and tested there on all the iPhone models I could find (5, 6 and 7 & S/Plus). I am confirming that the autocomplete does not work on any devices on 0.17.2.

I tested on one particular iPhone 6s and I am confirming that autocomplete does not work on any versions 0.16.0 and up (haven't tested lower), and does not work on any browsers (Safari, Chrome and Firefox).

Looks like the popup appears but is not positioned underneath the input. It might be related to #3638

@mbrookes
Copy link
Member

@taakan I just tested AutoComplete on the docs site on 5s, and it seems fine. I'm sure if the problem was that widespread since 0.16.7 we'd have heard before now...

@Taakn
Copy link
Author

Taakn commented Apr 11, 2017

Once again it worked on another iPhone 6 (regular, not S or Plus). So the bug seems to depend on some parameter I haven't identfied yet. I've spent several hours this afternoon finding different iPhones and going to an Apple Store to test, so up to you if you want to dismiss it like that

@mbrookes
Copy link
Member

so up to you if you want to dismiss it like that

@Taakn No need for the snark.; that is a good way to get your issue dismissed.

Once again it worked on another iPhone 6

At no point have you mentioned that, only that it works on emulators. In fact, you specifically mentioned that it didn't work on the iPhone 6 in the Apple Store.

What version of iOS is the working iPhone 6 running? Have you considered that this might be an iOS 10.3 issue, which would explain why it works on iPhone and not another? That would also explain why it's a recent issue.

@Taakn Taakn closed this as completed Apr 11, 2017
@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants