From ed823fffef6fc2f55c6b625579e09fdbc53e3273 Mon Sep 17 00:00:00 2001
From: fyodore82 <fyodor_e@hotmail.com>
Date: Tue, 28 Jan 2020 12:06:34 +1000
Subject: [PATCH 1/7] [Select] Right click opens select menu

---
 .../material-ui/src/Select/SelectInput.js     |  4 ++++
 .../test/integration/Select.test.js           | 23 +++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/packages/material-ui/src/Select/SelectInput.js b/packages/material-ui/src/Select/SelectInput.js
index b809d3cbdc6c88..2e2c689af511e7 100644
--- a/packages/material-ui/src/Select/SelectInput.js
+++ b/packages/material-ui/src/Select/SelectInput.js
@@ -105,6 +105,9 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
   };
 
   const handleMouseDown = event => {
+    if (event.button !== 0)
+      // ignore everything but left-click
+      return;
     // Hijack the default focus behavior.
     event.preventDefault();
     displayNode.focus();
@@ -318,6 +321,7 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
         aria-haspopup="listbox"
         onKeyDown={handleKeyDown}
         onMouseDown={disabled || readOnly ? null : handleMouseDown}
+        onClick={disabled || readOnly ? null : handleMouseDown}
         onBlur={handleBlur}
         onFocus={onFocus}
         {...SelectDisplayProps}
diff --git a/packages/material-ui/test/integration/Select.test.js b/packages/material-ui/test/integration/Select.test.js
index b8d4e52b8b5f3c..0644dcb5c60017 100644
--- a/packages/material-ui/test/integration/Select.test.js
+++ b/packages/material-ui/test/integration/Select.test.js
@@ -91,6 +91,29 @@ describe('<Select> integration', () => {
       expect(trigger).to.have.focus;
       expect(trigger).to.have.text('Twenty');
     });
+
+    it('open only with left mouse button click', () => {
+      // test for https://github.com/mui-org/material-ui/issues/19250#issuecomment-578620934
+      // right/middle mouse click shouldn't open select
+      const { getByRole, queryByRole, getByTestId } = render(<SelectAndDialog />);
+
+      const trigger = getByRole('button');
+
+      // Click by the left mouse button. Options list should be present
+      fireEvent.mouseDown(trigger);
+      expect(queryByRole('listbox')).to.not.be.null;
+
+      // Not close the options list.
+      getByTestId('select-backdrop').click();
+      clock.tick(0);
+
+      // If clicked by the right/middle mouse button, no options list should be opened
+      fireEvent.mouseDown(trigger, { button: 1 });
+      expect(queryByRole('listbox')).to.be.null;
+
+      fireEvent.mouseDown(trigger, { button: 2 });
+      expect(queryByRole('listbox')).to.be.null;
+    });
   });
 
   describe('with label', () => {

From b13994944157a7969038d769dc1d5e5964959c45 Mon Sep 17 00:00:00 2001
From: fyodore82 <fyodor_e@hotmail.com>
Date: Tue, 28 Jan 2020 12:09:28 +1000
Subject: [PATCH 2/7] [Select] Right click opens select menu

---
 packages/material-ui/src/Select/SelectInput.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/material-ui/src/Select/SelectInput.js b/packages/material-ui/src/Select/SelectInput.js
index 2e2c689af511e7..c4c230aa393e81 100644
--- a/packages/material-ui/src/Select/SelectInput.js
+++ b/packages/material-ui/src/Select/SelectInput.js
@@ -321,7 +321,6 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
         aria-haspopup="listbox"
         onKeyDown={handleKeyDown}
         onMouseDown={disabled || readOnly ? null : handleMouseDown}
-        onClick={disabled || readOnly ? null : handleMouseDown}
         onBlur={handleBlur}
         onFocus={onFocus}
         {...SelectDisplayProps}

From 2a9aa4bb32fa30ef94310c3d6759f3493e03f574 Mon Sep 17 00:00:00 2001
From: fyodore82 <fyodor_e@hotmail.com>
Date: Tue, 28 Jan 2020 12:11:10 +1000
Subject: [PATCH 3/7] Typos corrected

---
 packages/material-ui/test/integration/Select.test.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/material-ui/test/integration/Select.test.js b/packages/material-ui/test/integration/Select.test.js
index 0644dcb5c60017..77b2792de24bd4 100644
--- a/packages/material-ui/test/integration/Select.test.js
+++ b/packages/material-ui/test/integration/Select.test.js
@@ -93,8 +93,8 @@ describe('<Select> integration', () => {
     });
 
     it('open only with left mouse button click', () => {
-      // test for https://github.com/mui-org/material-ui/issues/19250#issuecomment-578620934
-      // right/middle mouse click shouldn't open select
+      // Test for https://github.com/mui-org/material-ui/issues/19250#issuecomment-578620934
+      // Right/middle mouse click shouldn't open the select
       const { getByRole, queryByRole, getByTestId } = render(<SelectAndDialog />);
 
       const trigger = getByRole('button');
@@ -103,7 +103,7 @@ describe('<Select> integration', () => {
       fireEvent.mouseDown(trigger);
       expect(queryByRole('listbox')).to.not.be.null;
 
-      // Not close the options list.
+      // Now close the options list.
       getByTestId('select-backdrop').click();
       clock.tick(0);
 

From 37ebffd9579d68349f64f9f8a1e3fdcaba217531 Mon Sep 17 00:00:00 2001
From: fyodore82 <fyodor_e@hotmail.com>
Date: Wed, 29 Jan 2020 08:57:45 +1000
Subject: [PATCH 4/7] [Select] Move test to UnitTests

---
 .../material-ui/src/Select/Select.test.js     | 38 +++++++++++++++++++
 .../test/integration/Select.test.js           | 23 -----------
 2 files changed, 38 insertions(+), 23 deletions(-)

diff --git a/packages/material-ui/src/Select/Select.test.js b/packages/material-ui/src/Select/Select.test.js
index 96ab71eb3562f3..54e6c23aa98aff 100644
--- a/packages/material-ui/src/Select/Select.test.js
+++ b/packages/material-ui/src/Select/Select.test.js
@@ -671,6 +671,44 @@ describe('<Select />', () => {
 
       expect(getByRole('listbox')).to.be.ok;
     });
+
+    it('open only with the left mouse button click', () => {
+      // Test for https://github.com/mui-org/material-ui/issues/19250#issuecomment-578620934
+      // Right/middle mouse click shouldn't open the select
+      const { getByRole, queryByRole, getByTestId } = render(
+        <Select
+          MenuProps={{
+            transitionDuration: 0,
+            BackdropProps: { 'data-testid': 'select-backdrop' },
+          }}
+          value=""
+        >
+          <MenuItem value="">
+            <em>None</em>
+          </MenuItem>
+          <MenuItem value={10}>Ten</MenuItem>
+          <MenuItem value={20}>Twenty</MenuItem>
+          <MenuItem value={30}>Thirty</MenuItem>
+        </Select>,
+      );
+
+      const trigger = getByRole('button');
+
+      // Click by the left mouse button. Options list should be present
+      fireEvent.mouseDown(trigger);
+      expect(queryByRole('listbox')).to.be.ok;
+
+      // Now close the options list.
+      getByTestId('select-backdrop').click();
+      clock.tick(0);
+
+      // If clicked by the right/middle mouse button, no options list should be opened
+      fireEvent.mouseDown(trigger, { button: 1 });
+      expect(queryByRole('listbox')).to.not.exist;
+
+      fireEvent.mouseDown(trigger, { button: 2 });
+      expect(queryByRole('listbox')).to.not.exist;
+    });
   });
 
   describe('prop: autoWidth', () => {
diff --git a/packages/material-ui/test/integration/Select.test.js b/packages/material-ui/test/integration/Select.test.js
index 77b2792de24bd4..b8d4e52b8b5f3c 100644
--- a/packages/material-ui/test/integration/Select.test.js
+++ b/packages/material-ui/test/integration/Select.test.js
@@ -91,29 +91,6 @@ describe('<Select> integration', () => {
       expect(trigger).to.have.focus;
       expect(trigger).to.have.text('Twenty');
     });
-
-    it('open only with left mouse button click', () => {
-      // Test for https://github.com/mui-org/material-ui/issues/19250#issuecomment-578620934
-      // Right/middle mouse click shouldn't open the select
-      const { getByRole, queryByRole, getByTestId } = render(<SelectAndDialog />);
-
-      const trigger = getByRole('button');
-
-      // Click by the left mouse button. Options list should be present
-      fireEvent.mouseDown(trigger);
-      expect(queryByRole('listbox')).to.not.be.null;
-
-      // Now close the options list.
-      getByTestId('select-backdrop').click();
-      clock.tick(0);
-
-      // If clicked by the right/middle mouse button, no options list should be opened
-      fireEvent.mouseDown(trigger, { button: 1 });
-      expect(queryByRole('listbox')).to.be.null;
-
-      fireEvent.mouseDown(trigger, { button: 2 });
-      expect(queryByRole('listbox')).to.be.null;
-    });
   });
 
   describe('with label', () => {

From 7f99cdace5e4f07682e7709059eeecde00df0791 Mon Sep 17 00:00:00 2001
From: fyodore82 <fyodor_e@hotmail.com>
Date: Wed, 29 Jan 2020 17:55:36 +1000
Subject: [PATCH 5/7] [Select] Test only middle/right button click

---
 packages/material-ui/src/Select/Select.test.js | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/packages/material-ui/src/Select/Select.test.js b/packages/material-ui/src/Select/Select.test.js
index 54e6c23aa98aff..a4663727a9bd38 100644
--- a/packages/material-ui/src/Select/Select.test.js
+++ b/packages/material-ui/src/Select/Select.test.js
@@ -694,14 +694,6 @@ describe('<Select />', () => {
 
       const trigger = getByRole('button');
 
-      // Click by the left mouse button. Options list should be present
-      fireEvent.mouseDown(trigger);
-      expect(queryByRole('listbox')).to.be.ok;
-
-      // Now close the options list.
-      getByTestId('select-backdrop').click();
-      clock.tick(0);
-
       // If clicked by the right/middle mouse button, no options list should be opened
       fireEvent.mouseDown(trigger, { button: 1 });
       expect(queryByRole('listbox')).to.not.exist;

From f07d13bc8762ac78c513080a1f44bf32279af80e Mon Sep 17 00:00:00 2001
From: fyodore82 <fyodor_e@hotmail.com>
Date: Wed, 29 Jan 2020 19:12:18 +1000
Subject: [PATCH 6/7] [Select] Cleanup unused staff

---
 packages/material-ui/src/Select/Select.test.js | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/packages/material-ui/src/Select/Select.test.js b/packages/material-ui/src/Select/Select.test.js
index a4663727a9bd38..6cf5577a186a38 100644
--- a/packages/material-ui/src/Select/Select.test.js
+++ b/packages/material-ui/src/Select/Select.test.js
@@ -675,14 +675,8 @@ describe('<Select />', () => {
     it('open only with the left mouse button click', () => {
       // Test for https://github.com/mui-org/material-ui/issues/19250#issuecomment-578620934
       // Right/middle mouse click shouldn't open the select
-      const { getByRole, queryByRole, getByTestId } = render(
-        <Select
-          MenuProps={{
-            transitionDuration: 0,
-            BackdropProps: { 'data-testid': 'select-backdrop' },
-          }}
-          value=""
-        >
+      const { getByRole, queryByRole } = render(
+        <Select value="">
           <MenuItem value="">
             <em>None</em>
           </MenuItem>

From 240573be1452a67b9f0a64b40d43fa19b0b95931 Mon Sep 17 00:00:00 2001
From: fyodore82 <fyodor_e@hotmail.com>
Date: Wed, 29 Jan 2020 21:08:00 +1000
Subject: [PATCH 7/7] [Select] Cleanup unused staff

---
 packages/material-ui/src/Select/Select.test.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/material-ui/src/Select/Select.test.js b/packages/material-ui/src/Select/Select.test.js
index 6cf5577a186a38..e9abdf7930e9dc 100644
--- a/packages/material-ui/src/Select/Select.test.js
+++ b/packages/material-ui/src/Select/Select.test.js
@@ -674,7 +674,7 @@ describe('<Select />', () => {
 
     it('open only with the left mouse button click', () => {
       // Test for https://github.com/mui-org/material-ui/issues/19250#issuecomment-578620934
-      // Right/middle mouse click shouldn't open the select
+      // Right/middle mouse click shouldn't open the Select
       const { getByRole, queryByRole } = render(
         <Select value="">
           <MenuItem value="">