[WIP][Core] Remove style-resizable mixin #2934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The styles-resizable mixin is only used in one component: `snackbar.jsx`. It's used to see if the window.innerWidth is less than 768. This commit makes snackbar do a manual check against window to remove the mixin. Signed-off-by: Neil Gabbadon <[email protected]>
| @@ -236,7 +234,7 @@ const Snackbar = React.createClass({ | |||
| actionColor, | |||
| } = this.constructor.getRelevantContextKeys(this.state.muiTheme); | |||
|
|
|||
| const isSmall = this.state.deviceSize === this.constructor.Sizes.SMALL; | |||
| const isSmall = window.innerWidth < 768; | |||
There was a problem hiding this comment.
What if the screen is rezised?
The component won't rerender 😁
There was a problem hiding this comment.
True, on one hand I figured this shouldn't matter to much because:
- Snackbars are generally temporary
- The resolution of small devices typically does not change
Though on second thought, there are some other considerations like the width as a result from a orientation change.
|
#2861 is using this mixin 😁. |
|
@oliviertassinari Yikes! Thanks for pointing that out. Mm...okay. Maybe we're going to have to come up with a closer to permanent solution before dropping this one. 😞 |
newoga
changed the title
newoga
added
the
PR: needs revision
|
@oliviertassinari This approach isn't going to work and (I think) you will be taking this on soon. Either way, we can open up a new PR that remove this mixin. I'm closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
styles-resizable mixinis only used in one component:snackbar.jsx. It's used to see if thewindow.innerWidthis less than 768. This commit makes snackbar do a manual check against window to remove the mixin.Let me know if you think we should deprecate instead of remove. I do think we need to revisit responsiveness but I don't think this mixin got us too far since it was only used in one component and the breakpoints used in the mixin (992 and 768) do not follow the spec.
I think we could probably create an issue as a reminder than there's a manual check being done for snackbar. Maybe we should create a Responsive issue label as well?