[Badge] Remove style-propable mixin

[newoga]

No description provided.

[alitaheri]

You really like ternary monsters 😆 😆 what's wrong with let + if/else chain? 😆

[newoga]

Haha! 😅 😅 That monster (I agree it's a monster) was an attempt to make the previous ternary simpler:

const badgeBackgroundColor = this.props.primary
  ? theme.primaryColor
  : this.props.secondary
    ? theme.secondaryColor
    : theme.color;

const badgeTextColor = this.props.primary
  ? theme.primaryTextColor
  : this.props.secondary
    ? theme.secondaryTextColor
    : theme.textColor;

I can switch it to use let + if/else even though lets make me sad 😁 Though I agree, ternarys beyond one level deep are too complicated.

[mbrookes]

Refering to the example @newoga quoted - Perfectly readable. I think it's just what you're used to. To me this is the perfect use case for nested ternaries. (But what do I know?! 😆 )

This on the other hand:

  const [
    badgeBackgroundColor,
    badgeTextColor,
  ] = primary ? [badge.primaryColor, badge.primaryTextColor] :
    secondary ? [badge.secondaryColor, badge.secondaryTextColor] :
    [badge.color, badge.textColor];

😱

[newoga]

I think it's just what you're used to.

I agree, I suppose the standard if/else is probably easiest for most though.

[alitaheri]

@newoga You're doing an awesome job. thanks a lot 👍

[newoga]

@newoga You're doing an awesome job. thanks a lot 👍

Thanks @alitaheri!

[newoga]

Done:

1. Switch the setState to use nextContext.muiTheme || this.state.muiTheme.
2. Simplified primary and secondary checks to if-else

[alitaheri]

Awesome job @newoga 👍 👍

All green here 😄

[oliviertassinari]

Don't worry too much about this. The es6 class codmode add them automatically.

[newoga]

Good point! Thanks for reminding me. I'd say 80+% of the components I've switched so far are candidates/ready to be switched to classes using the codemod 👍

[oliviertassinari]

@newoga Thanks!