[Button] Remove style-propable mixin from flat-button-label #3197
Conversation
newoga
changed the title
|
|
||
| return ( | ||
| <span style={this.prepareStyles(mergedRootStyles)}>{label}</span> | ||
| <span style={prepareStyles(styles.root, style)}>{label}</span> |
There was a problem hiding this comment.
from what I understand from the transformer chain that is prepareStyles it only takes 1 argument. so style will probably be ignored. I think you should Object.assign({},...) this too.
There was a problem hiding this comment.
Oh geez, good catch! I actually had meant to enable a warning for that too so we could catch it similarly to callOnce.
I think I might do that but not commit it because it's probably going to complain a lot with all the mixin implementations often using prepareStyles with multiple arguments.
There was a problem hiding this comment.
a warning is interesting 👍 It will catch all these misuses. good idea 👍
There was a problem hiding this comment.
😆 😆 The docs site got very angry with me.
newoga
force-pushed
the
#2852/flat-button-label
branch
from
01e35f1
to
927ce03
Compare
|
All good 👍 😁 |
| @@ -61,19 +71,16 @@ const FlatButtonLabel = React.createClass({ | |||
| style, | |||
| } = this.props; | |||
|
|
|||
| const contextKeys = this.constructor.getRelevantContextKeys(this.state.muiTheme); | |||
There was a problem hiding this comment.
👍 We should get rid of this ContextPure too.
[Button] Remove style-propable mixin from flat-button-label
|
@newoga Thanks! |
zannager
added
the
component: button
No description provided.