Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EnhancedSwitch] Remove style-propable mixin #3255

Merged
merged 1 commit into from
Feb 11, 2016
Merged

[EnhancedSwitch] Remove style-propable mixin #3255

merged 1 commit into from
Feb 11, 2016

Conversation

newoga
Copy link
Contributor

@newoga newoga commented Feb 9, 2016

No description provided.

@yongxu yongxu mentioned this pull request Feb 9, 2016
Closed
90 tasks
alitaheri
alitaheri reviewed Feb 9, 2016
View reviewed changes
src/enhanced-switch.jsx
baseTheme,
} = state.muiTheme;

let switchWidth = 60 - baseTheme.spacing.desktopGutterLess;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are used in singular places so i think you can replace them with their usage :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good call, thanks!

@newoga
Copy link
Contributor Author

newoga commented Feb 9, 2016

  • Removed unnecessary variable declarations that were used a single time (comment)

@alitaheri
Copy link
Member

All good here, thanks a lot 👍 👍

@oliviertassinari
Copy link
Member

There is an issue with the margin here.
capture d ecran 2016-02-10 a 09 05 39

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Feb 10, 2016
@newoga newoga closed this Feb 10, 2016
@newoga newoga deleted the #2852/enhanced-switch branch February 10, 2016 14:28
@newoga newoga restored the #2852/enhanced-switch branch February 10, 2016 14:29
@newoga newoga reopened this Feb 10, 2016
@newoga newoga added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 11, 2016
@newoga
Copy link
Contributor Author

newoga commented Feb 11, 2016

  • Fixed regression on docs site where margins weren't applied due to prepareStyles call with multiple arguments. (comment)

@alitaheri
Copy link
Member

Looking good 👍 👍

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Feb 11, 2016
@oliviertassinari
Copy link
Member

I have noticed the following issue:
fevr 11 2016 13 44
However, that seems to be already broken on the master branch.

@newoga
Copy link
Contributor Author

newoga commented Feb 11, 2016

Mm, good catch! That one might be tricky to find. Probably clearfix or one of the ripples.

@newoga newoga mentioned this pull request Feb 11, 2016
Merged
@newoga newoga added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 11, 2016
@newoga
Copy link
Contributor Author

newoga commented Feb 11, 2016

oliviertassinari added a commit that referenced this pull request Feb 11, 2016
@oliviertassinari
Merge pull request #3255 from newoga/#2852/enhanced-switch
722f9d7 
[EnhancedSwitch] Remove style-propable mixin
@oliviertassinari oliviertassinari merged commit 722f9d7 into mui:master Feb 11, 2016
@oliviertassinari
Copy link
Member

@newoga Thanks!

@newoga newoga deleted the #2852/enhanced-switch branch February 13, 2016 15:50
@zannager zannager added the component: switch This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: switch This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@newoga @alitaheri @oliviertassinari @zannager