[RaisedButton] Remove style-propable mixin #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 tasks
| } else if (props.secondary) { | ||
| backgroundColor = raisedButton.secondaryColor; | ||
| labelColor = raisedButton.secondaryTextColor; | ||
| } |
There was a problem hiding this comment.
All my nagging have finally paid off 😍 😆 😆
Although the extra props. seems unnecessary O.o
There was a problem hiding this comment.
Haha you never gave up on me! 😆
Good call on the props!
oliviertassinari
added
PR: needs revision
newoga
force-pushed
the
#2852/raised-button
branch
from
5b5afc9
to
0cfbfb0
Compare
newoga
force-pushed
the
#2852/raised-button
branch
from
0cfbfb0
to
8587247
Compare
newoga
added
PR: Needs Review
and removed
PR: needs revision
|
Alright this is great 👍 👍 |
@newoga I can see that 👏. |
oliviertassinari
added a commit
that referenced
this pull request
Feb 11, 2016
[RaisedButton] Remove style-propable mixin
zannager
added
component: button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was not easy. It's much improved I think but could probably use a revisit one day.