From 6f690fd4248e71b2f05502c14bfb4bc1269acf27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aar=C3=B3n=20Garc=C3=ADa=20Herv=C3=A1s?= Date: Wed, 19 Jun 2024 15:02:28 +0200 Subject: [PATCH 1/9] Remove findOutermostIntrinsic test util --- .../src/findOutermostIntrinsic.test.js | 68 ------------------- .../test-utils/src/findOutermostIntrinsic.ts | 19 ------ packages-internal/test-utils/src/index.ts | 1 - 3 files changed, 88 deletions(-) delete mode 100644 packages-internal/test-utils/src/findOutermostIntrinsic.test.js delete mode 100644 packages-internal/test-utils/src/findOutermostIntrinsic.ts diff --git a/packages-internal/test-utils/src/findOutermostIntrinsic.test.js b/packages-internal/test-utils/src/findOutermostIntrinsic.test.js deleted file mode 100644 index f5d9b21e4c6cb6..00000000000000 --- a/packages-internal/test-utils/src/findOutermostIntrinsic.test.js +++ /dev/null @@ -1,68 +0,0 @@ -import * as React from 'react'; -import { expect } from 'chai'; -import createMount from './createMount'; -import findOutermostIntrinsic from './findOutermostIntrinsic'; - -describe('findOutermostIntrinsic', () => { - const mount = createMount({ strict: null }); - const expectIntrinsic = (node, expected) => { - const wrapper = mount(node); - const outermostIntrinsic = findOutermostIntrinsic(wrapper); - - if (expected === null) { - expect(outermostIntrinsic.exists()).to.equal(false); - } else { - expect(outermostIntrinsic.type()).to.equal(expected); - expect(outermostIntrinsic.type()).to.equal( - outermostIntrinsic.getDOMNode().nodeName.toLowerCase(), - ); - } - }; - const Headless = ({ children }) => children; - - it('returns immediate DOM nodes', () => { - expectIntrinsic(
Hello, World!
, 'div'); - }); - - it('only returns the outermost', () => { - expectIntrinsic( - -
Hello, World!
-
, - 'span', - ); - }); - - it('ignores components', () => { - expectIntrinsic( - -
Hello, World!
-
, - 'div', - ); - expectIntrinsic( - - -
Hello, World!
-
-
, - 'div', - ); - expectIntrinsic( - - -
- - Hello, World! - -
-
-
, - 'div', - ); - }); - - it('can handle that no DOM node is rendered', () => { - expectIntrinsic({false && }, null); - }); -}); diff --git a/packages-internal/test-utils/src/findOutermostIntrinsic.ts b/packages-internal/test-utils/src/findOutermostIntrinsic.ts deleted file mode 100644 index ed1c1372d9bd39..00000000000000 --- a/packages-internal/test-utils/src/findOutermostIntrinsic.ts +++ /dev/null @@ -1,19 +0,0 @@ -import { ReactWrapper } from 'enzyme'; - -/** - * checks if a given react wrapper wraps an intrinsic element i.e. a DOM node - * @param {import('enzyme').ReactWrapper} reactWrapper - * @returns {boolean} true if the given reactWrapper wraps an intrinsic element - */ -export function wrapsIntrinsicElement(reactWrapper: ReactWrapper): boolean { - return typeof reactWrapper.type() === 'string'; -} - -/** - * like ReactWrapper#getDOMNode() but returns a ReactWrapper - * @param {import('enzyme').ReactWrapper} reactWrapper - * @returns {import('enzyme').ReactWrapper} the wrapper for the outermost DOM node - */ -export default function findOutermostIntrinsic(reactWrapper: ReactWrapper): ReactWrapper { - return reactWrapper.findWhere((n) => n.exists() && wrapsIntrinsicElement(n)).first(); -} diff --git a/packages-internal/test-utils/src/index.ts b/packages-internal/test-utils/src/index.ts index 6f0e1527448056..c8effe15dc7e68 100644 --- a/packages-internal/test-utils/src/index.ts +++ b/packages-internal/test-utils/src/index.ts @@ -6,7 +6,6 @@ export * from './describeConformance'; export { default as createDescribe } from './createDescribe'; export * from './createRenderer'; export { default as createMount } from './createMount'; -export { default as findOutermostIntrinsic, wrapsIntrinsicElement } from './findOutermostIntrinsic'; export { default as focusVisible, simulatePointerDevice, From 6baa01c5ff7bab7269d7a4d43cc38afae1aee015 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aar=C3=B3n=20Garc=C3=ADa=20Herv=C3=A1s?= Date: Wed, 19 Jun 2024 15:12:07 +0200 Subject: [PATCH 2/9] Remove unused mount param from describeConformanceUnstyled calls --- packages/mui-base/src/Badge/Badge.test.tsx | 4 +--- packages/mui-base/src/Button/Button.test.tsx | 4 +--- .../src/FormControl/FormControl.test.tsx | 4 +--- packages/mui-base/src/Input/Input.test.tsx | 4 +--- packages/mui-base/src/Menu/Menu.test.tsx | 8 -------- .../src/MenuButton/MenuButton.test.tsx | 9 +-------- .../mui-base/src/MenuItem/MenuItem.test.tsx | 7 +------ packages/mui-base/src/Modal/Modal.test.tsx | 4 +--- packages/mui-base/src/Option/Option.test.tsx | 19 +------------------ .../src/OptionGroup/OptionGroup.test.tsx | 4 +--- packages/mui-base/src/Popper/Popper.test.tsx | 4 +--- packages/mui-base/src/Select/Select.test.tsx | 3 --- packages/mui-base/src/Slider/Slider.test.tsx | 4 +--- .../mui-base/src/Snackbar/Snackbar.test.tsx | 5 +---- packages/mui-base/src/Switch/Switch.test.tsx | 4 +--- packages/mui-base/src/Tab/Tab.test.tsx | 19 +------------------ .../mui-base/src/TabPanel/TabPanel.test.tsx | 7 +------ .../TablePagination/TablePagination.test.tsx | 13 +------------ packages/mui-base/src/Tabs/Tabs.test.tsx | 4 +--- .../mui-base/src/TabsList/TabsList.test.tsx | 19 +------------------ .../TextareaAutosize.test.tsx | 11 +---------- .../Unstable_NumberInput/NumberInput.test.tsx | 4 +--- .../src/Unstable_Popup/Popup.test.tsx | 4 +--- 23 files changed, 21 insertions(+), 147 deletions(-) diff --git a/packages/mui-base/src/Badge/Badge.test.tsx b/packages/mui-base/src/Badge/Badge.test.tsx index 57a1e60771a831..2d81bc5290296d 100644 --- a/packages/mui-base/src/Badge/Badge.test.tsx +++ b/packages/mui-base/src/Badge/Badge.test.tsx @@ -1,11 +1,10 @@ import * as React from 'react'; -import { createRenderer, createMount } from '@mui/internal-test-utils'; +import { createRenderer } from '@mui/internal-test-utils'; import { Badge, badgeClasses as classes } from '@mui/base/Badge'; import { describeConformanceUnstyled } from '../../test/describeConformanceUnstyled'; describe('', () => { const { render } = createRenderer(); - const mount = createMount(); describeConformanceUnstyled( @@ -15,7 +14,6 @@ describe('', () => { classes, inheritComponent: 'span', render, - mount, refInstanceof: window.HTMLSpanElement, testComponentPropWith: 'div', slots: { diff --git a/packages/mui-base/src/Button/Button.test.tsx b/packages/mui-base/src/Button/Button.test.tsx index 5c47b422cf2c4b..95a89a1d7d7d08 100644 --- a/packages/mui-base/src/Button/Button.test.tsx +++ b/packages/mui-base/src/Button/Button.test.tsx @@ -1,18 +1,16 @@ import * as React from 'react'; -import { act, createMount, createRenderer, fireEvent } from '@mui/internal-test-utils'; +import { act, createRenderer, fireEvent } from '@mui/internal-test-utils'; import { expect } from 'chai'; import { spy } from 'sinon'; import { Button, buttonClasses } from '@mui/base/Button'; import { describeConformanceUnstyled } from '../../test/describeConformanceUnstyled'; describe('