Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MobileDatePicker] Broken ARIA reference #5632

Closed
2 tasks done
212817 opened this issue Jul 27, 2022 · 1 comment · Fixed by #7608
Closed
2 tasks done

[MobileDatePicker] Broken ARIA reference #5632

212817 opened this issue Jul 27, 2022 · 1 comment · Fixed by #7608
Assignees
Labels
accessibility a11y component: DatePicker The React component. component: pickers This is the name of the generic UI component, not the React module!

Comments

@212817
Copy link

212817 commented Jul 27, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When scanning for accessibility issues using the app Wave. The MobileDatePicker generate the follow issue:
"Broken ARIA reference "

Expected behavior 🤔

The MobileDatePicker should not generate any accessibility issues.

Steps to reproduce 🕹

Link to live example:
https://codesandbox.io/s/responsivedatepickers-demo-mui-x-forked-wuwiu7?file=/demo.tsx

Steps:

  1. Install the Wave extension in a chrome browser.
  2. Click on the MobileDatePicker or DatePiker with props desktopModeMediaQuery='never' to open a selection window
  3. Scan the page with a Date Picker on.

MicrosoftTeams-image

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID 💳 (optional)

No response

@212817 212817 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 27, 2022
@cherniavskii
Copy link
Member

Thanks @212817
There's missing aria-labelledby prop passed to Dialog here:

<PickersModalDialogRoot open={open} onClose={onDismiss} {...DialogProps}>

that should point to the id of the title component in here:

<Typography data-mui-test="picker-toolbar-title" color="text.secondary" variant="overline">
{toolbarTitle}

@cherniavskii cherniavskii added accessibility a11y component: pickers This is the name of the generic UI component, not the React module! component: DatePicker The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 2, 2022
@LukasTy LukasTy self-assigned this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: DatePicker The React component. component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants