Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Rows ordering reverted after finishing cell editing #6520

Closed
2 tasks done
thuatole opened this issue Oct 15, 2022 · 5 comments
Closed
2 tasks done

[data grid] Rows ordering reverted after finishing cell editing #6520

thuatole opened this issue Oct 15, 2022 · 5 comments
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Reordering Related to the data grid Reordering feature plan: Premium Impact at least one Premium user

Comments

@thuatole
Copy link

thuatole commented Oct 15, 2022 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Rows ordering reverted after enabling cell edit mode

Expected behavior 🤔

Keep the order after finishing cell editing

Steps to reproduce 🕹

Link to live example: https://www.loom.com/share/12c438f1a1b34568a178c3d00a836d23

Steps:

  1. Change the order of rows number 1 and 2
  2. Edit column name of row number 2
  3. Click outside to finish editing
  4. See the order has been reverted

Context 🔦

No response

Your environment 🌎

https://codesandbox.io/s/pensive-mcnulty-efdyxo?file=/demo.tsx

Order ID 💳 (optional)

46630
@thuatole thuatole added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 15, 2022
@yaredtsy
Copy link
Contributor

@thuatole I think it's fixed on 'v6' or 'next', this is the doc https://next.mui.com/x/react-data-grid/editing/, and this is the demo link https://codesandbox.io/s/optimistic-williams-qtm6ye

@thuatole
Copy link
Author

thanks @yaredtsy

@flaviendelangle flaviendelangle changed the title [Grid premium]Rows ordering reverted after finishing cell editing [data grid] Rows ordering reverted after finishing cell editing Oct 17, 2022
@flaviendelangle flaviendelangle added the plan: Premium Impact at least one Premium user label Oct 17, 2022
@yaredtsy
Copy link
Contributor

@alexfauquette this is not fixed on master. setRowIndex is not updating caches.rows , every time updateRows is called it is reverting row orders.

@alexfauquette
Copy link
Member

@yaredtsy Thanks for your investigation, but I'm not working on this part of the data grid

@flaviendelangle flaviendelangle added the component: data grid This is the name of the generic UI component, not the React module! label Oct 17, 2022
@cherniavskii cherniavskii added bug 🐛 Something doesn't work feature: Reordering Related to the data grid Reordering feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 17, 2022
@cherniavskii cherniavskii mentioned this issue Oct 17, 2022
Merged
@cherniavskii
Copy link
Member

Closed by #6544?
For some reason, the issue wasn't closed automatically 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Reordering Related to the data grid Reordering feature plan: Premium Impact at least one Premium user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@flaviendelangle @thuatole @cherniavskii @yaredtsy @alexfauquette