-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate icons for improved skinning #1574
Comments
This issue is compiled of both the issue of allowing different assets for different areas while also not breaking existing themes. We already separated a few icons in the snapshot in this commit, but if we're gonna change more icons it might be better to not completely break all existing themes. A relatively simple way would be to check for the existence of specific icon, and if not found, fallback to the "generic" icon. A better way to differentiate these without using long names like deafened_self_toolbutton.svg would be to make directories depending on use, for example user/deafened_self, toolbar/deafened_self.svg and tray/deafened_self.svg, etc. In this list, "toolbutton" means a button on the toolbar, "indicator" means an icon to the right side of a user/channel, "avatar" means icon to the left of a user/channel, and "tray" means the icon shown in the taskbar tray area. Doing this by memory, hopefully I'm not missing anything. deafened_self.svg - self deafened toolbutton / indicator / tray / generic "deafened" indicator in overlay actions/audio-input-microphone.svg * - unmuted state toolbutton / priority speaker indicator
|
http://forums.mumble.info/viewtopic.php?f=8&t=1245 describes issues with selectively skinning toolbar icons. We reuse the same icon in a lot of places that might require individual adjustment for where they will appear.
@xpoke is probably the one in the best position to suggest where we have issues with that and how to solve them. Especially when it comes to what's possible from QSS and what we have to do by offering separately named icon files that can be exchanged. Also this issue might exist for more icons than mentioned in the post.
The text was updated successfully, but these errors were encountered: