Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAV audio cue sound files are playing inconsistently #6359

Open
Brottweiler opened this issue Mar 11, 2024 · 8 comments
Open

WAV audio cue sound files are playing inconsistently #6359

Brottweiler opened this issue Mar 11, 2024 · 8 comments
Labels
audio bug A bug (error) in the software client

Comments

@Brottweiler
Copy link

Description

When using audio cue, the sound is sometimes silent. It seems random, and happens both for ON and OFF.

Steps to reproduce

  1. Open settings
  2. Enable Audio cue when using Push To talk
  3. Apply
  4. Keep pressing Push To Talk repeatedly and you will notice that sometimes the ON and OFF cue does not play at all.

Mumble version

1.5.613

Mumble component

Client

OS

Linux

Reproducible?

Yes

Additional information

Upgraded from 1.5.517 → 1.5.613. In 1.5.517 audio cue works flawlessly. 1.5.613 has problems.

Relevant log output

No response

Screenshots

No response

@Brottweiler Brottweiler added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Mar 11, 2024
@Hartmnt
Copy link
Member

Hartmnt commented Mar 11, 2024

Hi,

4. Keep pressing Push To Talk repeatedly

What exactly do you mean with "repeatedly". The audio cue behavior was changed to first stop the currently active sound when switching to the other state. If you press and release PTT really fast, you would probably notice the samples stutter when using long samples. The change was done in #5926 and requested in #1671

Are you using audio cue samples which are longer than the original ones?

@Brottweiler
Copy link
Author

Brottweiler commented Mar 12, 2024

Press PTT, wait one second, release PTT, wait one second, repeat. My audio cue sound is the original Ventrilo PTT sound which is less than a second. So the sound file is short and I notice this issue when I talk with people on mumble in a normal fashion.

@Hartmnt
Copy link
Member

Hartmnt commented Mar 12, 2024

I tried to reproduce this, but it works as expected for me. Is there any way for me to download the original Ventrilo samples?

How often does the audio cue fail on a scale from every time to once an hour or something?

@Brottweiler
Copy link
Author

Brottweiler commented Mar 12, 2024

Here is a video demonstrating the issue. You can notice twice that the audio is silent when using PTT.
PTT.webm

You seem to be right that I cannot seem to reproduce it using the default audio cue sounds.. unless it happens much more rarely.
I have made an archive with the PTT sounds you can download here and test with. PTT.tar.gz

@Hartmnt
Copy link
Member

Hartmnt commented Mar 12, 2024

Here is a video demonstrating the issue. You can notice twice that the audio is silent when using PTT. PTT.webm

You seem to be right that I cannot seem to reproduce it using the default audio cue sounds.. unless it happens much more rarely. I have made an archive with the PTT sounds you can download here and test with. PTT.tar.gz

Oh wow. I can reproduce your issue with the provided sound files. But using the default client audio cues and other .ogg files works just fine for me. I wonder if this is a race condition with the wav decoder, because if I remember correctly we read the sample each time it is played.

@Hartmnt Hartmnt added client audio and removed triage This issue is waiting to be triaged by one of the project members labels Mar 12, 2024
@Hartmnt
Copy link
Member

Hartmnt commented Mar 12, 2024

Converting your sound files to .ogg using ffmpeg solves the problem, too. This is very likely some kind of wav decode bug.

@Brottweiler
Copy link
Author

Yep, converting the file to .ogg solves the issue. Thanks!

@Hartmnt
Copy link
Member

Hartmnt commented Mar 12, 2024

Yes, but lets keep the issue open as there is clearly something wrong with the wav decoding.

@Hartmnt Hartmnt changed the title Audio cue sound playing inconsistently WAV audio cue sound files are playing inconsistently Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio bug A bug (error) in the software client
Projects
None yet
Development

No branches or pull requests

2 participants