Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4 Issue] Engraving of two-note tremolos is not ideal #15470

Closed
Harmoniker1 opened this issue Dec 21, 2022 · 5 comments · Fixed by #16223
Closed

[MU4 Issue] Engraving of two-note tremolos is not ideal #15470

Harmoniker1 opened this issue Dec 21, 2022 · 5 comments · Fixed by #16223
Assignees
@oktophonie @asattely
Labels
engraving feature request Used to suggest improvements or new capabilities P0 Priority: Critical

Comments

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Dec 21, 2022 •
edited
Loading

Describe the bug
It is reported in this issue thread that the layout of two-note tremolos is not as good as in 3.6.

  • In 3.6, the two chords that share a two-note tremolo can have different stem directions, which is not allowed in 4.0.
  • The layout in 3.6 is also better when they have the same stem direction.

See these images for comparison:
image (MuseScore 3.6)
image (MuseScore 4.0 - the other one is not possible to achieve)

The second problem was fixed by me in #5619 I think (specifically 7450cbf), but the related code was probably removed and the behaviour was reverted to before the fix. @oktophonie Was this intended?

Platform information

  • OS: Windows 11
@SteveBlower
Copy link

Also reported on .org Issue Tracker https://musescore.org/en/node/339387

@oktophonie oktophonie self-assigned this Dec 21, 2022
@oktophonie oktophonie added the feature request Used to suggest improvements or new capabilities label Dec 21, 2022
@oktophonie
Copy link
Contributor

oktophonie commented Dec 21, 2022 •
edited
Loading

In an ideal world, tremolos would have been implemented as a flavour of beam, and so all the new beam placement code would apply to them to. Sadly this didn't turn out to be the case (they were a thing all unto themselves), and changing this required a refactoring effort that we didn't have time for for 4.0, so their current placement is, sadly, pretty gruesome. ('Not ideal' is an understatement.)

Rest assured that this is one of my highest prioirities for 4.1, though. (Yes, there will be options for symmetrical placement on unstemmed notes, and for going between them rather than above/below, etc)

@Harmoniker1
Copy link
Contributor Author

@oktophonie That's glad to hear! I would totally support treating two-note tremolos like beams. But meanwhile, does the current "gruesomeness" deserve a quick patch fix for minor releases?

@oktophonie
Copy link
Contributor

Not really interested in quick hacks to cover up larger problems; that's precisely what we're trying to get away from.

@Tantacrul
Copy link
Contributor

Not really interested in quick hacks to cover up larger problems; that's precisely what we're trying to get away from.

Exactly. When we do it right, we can then build upon that work. A hack has to be eventually removed, which then messes up people's scores.

@oktophonie oktophonie mentioned this issue Feb 6, 2023
Merged
@oktophonie oktophonie added engraving P0 Priority: Critical engraving and removed engraving labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oktophonie oktophonie

@asattely asattely

Labels
engraving feature request Used to suggest improvements or new capabilities P0 Priority: Critical
Projects
No open projects
MuseScore 4.1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Beam / tremolo layout refactor asattely/MuseScore
5 participants
@oktophonie @Tantacrul @Harmoniker1 @SteveBlower @asattely