fix(mux-player): Hide cast button by default when using DRM. #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
cjpillsbury
commented
Jun 5, 2024
| @@ -8,8 +8,16 @@ import { i18n, stylePropsToString } from './utils'; | |||
| import type { MuxTemplateProps } from './types'; | |||
| import { StreamTypes, toMuxVideoURL } from '@mux/playback-core'; | |||
|
|
|||
| const getPropsCSS = (props: MuxTemplateProps) => { | |||
| const { tokens } = props; | |||
| if (!tokens.drm) return ''; | |||
There was a problem hiding this comment.
obviously if/when we add additional property-specific styles here, we wouldn't want a simple if + early bail. Didn't want to over-architect the guts until we needed it tho.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DRM-protected content requires a custom receiver app for casting (https://support.google.com/widevine/answer/6072130?hl=en), hide the cast button by default whenever we encounter a drm token. Went ahead and introduced a simple generic concept (props-driven css) and a pattern (internal css vars as defaults) that we can conform to for these cases.