fix(mux-player): use CSS to disable subtitle shifting for iOS in fullscreen. #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
cjpillsbury
commented
Jul 25, 2024
| @@ -66,15 +66,27 @@ | |||
| * 0.433s is the transition duration for VTT Regions. | |||
| * Borrowed here, so the captions don't move too fast. | |||
| */ | |||
| media-controller ::slotted([slot='media']) { | |||
There was a problem hiding this comment.
NOTE: Although this change isn't technically required, custom CSS properties (aka "CSS variables") inherit, so removing the narrower selection since it's both unnecessary and adds specificity that is harder to override.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by muxinc/media-chrome#946
Fixes #863
Smoke tested 👍 on both iOS Safari and iOS Chrome, plus desktop browsers for regression testing.