Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to goformation #97

Open
mweagle opened this issue Jan 1, 2018 · 6 comments
Open

Upgrade to goformation #97

mweagle opened this issue Jan 1, 2018 · 6 comments
Labels
p2

Comments

@mweagle
Copy link
Owner

mweagle commented Jan 1, 2018

Sparta currently uses https://github.com/mweagle/go-cloudformation for CloudFormation marshalling. Evaluate whether there are benefits to migrating to https://github.com/awslabs/goformation, pending feature parity.

This is a reminder entry. Last checked: 1/1/2018
@mweagle mweagle added the p2 label Jan 1, 2018
@mweagle mweagle changed the title Reminder: Check AWS goformation for maturity Reminder: Check AWS goformation for parity Jan 1, 2018
@mweagle
Copy link
Owner Author

mweagle commented Sep 3, 2018

Fn:GetAtt remains unsupported.

@mweagle
Copy link
Owner Author

mweagle commented Oct 21, 2018

Fn:GetAtt remains unsupported.

@StevenACoffman StevenACoffman mentioned this issue Feb 5, 2019
Closed
@StevenACoffman
Copy link

Actually, they supported intrinsic functions in goformation 1.2.0 release in September, but never updated the documentation.

@mweagle
Copy link
Owner Author

mweagle commented Feb 22, 2019

Ah - thx @StevenACoffman. I was only checking the README :) I would like to migrate to this as part of a breaking v2 release at some point. WDYT?

@StevenACoffman
Copy link

I've not used either crewjam/go-cloudformation or awslabs/goformation so I can't compare either in terms of quality or ergonomics, but there's more contributors to the latter, and some of them are employed by AWS, so it might ease your maintenance burden to combine efforts. Seems fine to me.

@mweagle mweagle mentioned this issue Apr 6, 2019
Open
@mweagle mweagle changed the title Reminder: Check AWS goformation for parity Upgrade to goformation Apr 27, 2019
@mweagle
Copy link
Owner Author

mweagle commented Apr 27, 2019

Took a look and currently blocked by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweagle @StevenACoffman