Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few tests fail in the CI when Quarto is installed #1255

Open
mwouts opened this issue Jul 9, 2024 · 3 comments
Open

A few tests fail in the CI when Quarto is installed #1255

mwouts opened this issue Jul 9, 2024 · 3 comments
Assignees

Comments

@mwouts
Copy link
Owner

mwouts commented Jul 9, 2024

See for instance https://github.com/mwouts/jupytext/actions/runs/9826548787/job/27128181702

@mwouts mwouts self-assigned this Jul 9, 2024
@mwouts
Copy link
Owner Author

mwouts commented Jul 9, 2024

I can reproduce the failures locally with quarto==1.5.54.

The failing tests are

FAILED tests/external/contents_manager/test_contentsmanager_external.py::test_save_load_paired_qmd_notebook[ipynb_py/cat_variable.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:
FAILED tests/external/contents_manager/test_contentsmanager_external.py::test_save_load_paired_qmd_notebook[ipynb_py/frozen_cell.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:
FAILED tests/external/contents_manager/test_contentsmanager_external.py::test_save_load_paired_qmd_notebook[ipynb_julia/julia_benchmark_plotly_barchart.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:
FAILED tests/external/simple_external_notebooks/test_read_simple_quarto.py::test_qmd_to_ipynb - jupytext.compare.NotebookDifference: Notebook metadata differ: 
FAILED tests/external/contents_manager/test_contentsmanager_external.py::test_save_load_paired_qmd_notebook[ipynb_py/Notebook_with_more_R_magic_111.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:
FAILED tests/external/round_trip/test_mirror_external.py::test_ipynb_to_quarto[ipynb_py/cat_variable.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:
FAILED tests/external/round_trip/test_mirror_external.py::test_ipynb_to_quarto[ipynb_julia/julia_benchmark_plotly_barchart.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:
FAILED tests/external/round_trip/test_mirror_external.py::test_ipynb_to_quarto[ipynb_py/frozen_cell.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:
FAILED tests/external/round_trip/test_mirror_external.py::test_ipynb_to_quarto[ipynb_py/Notebook_with_more_R_magic_111.ipynb] - jupytext.compare.NotebookDifference: Unexpected cell type 'markdown' for code cell #1:

@mwouts
Copy link
Owner Author

mwouts commented Jul 9, 2024

The test tests/external/simple_external_notebooks/test_read_simple_quarto.py::test_qmd_to_ipynb highlights a difference on the kernelspecs. I am not sure what might cause this:

>               raise NotebookDifference(f"Notebook metadata differ: {str(error)}")
E               jupytext.compare.NotebookDifference: Notebook metadata differ: 
E               --- expected
E               +++ actual
E               @@ -1,7 +1,8 @@
E                {
E                 "kernelspec": {
E               -  "display_name": "python_kernel",
E               +  "display_name": "Python 3 (ipykernel)",
E                  "language": "python",
E               -  "name": "python_kernel"
E               +  "name": "python3",
E               +  "path": "/home/marc/.local/share/jupyter/kernels/python3"
E                 }
E                }

@mwouts
Copy link
Owner Author

mwouts commented Jul 9, 2024

Looking into tests/external/round_trip/test_mirror_external.py::test_ipynb_to_quarto[ipynb_py/cat_variable.ipynb], I see that the notebook now gets an extra markdown cell with this content:

{'cell_type': 'markdown', 'metadata': {}, 'source': '---\njupyter: python3\n---'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant