Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for groovy and java #500

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Conversation

jest
Copy link

@jest jest commented Apr 26, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #500 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   98.74%   98.75%           
=======================================
  Files          81       83    +2     
  Lines        8072     8098   +26     
=======================================
+ Hits         7971     7997   +26     
  Misses        101      101           
Impacted Files Coverage Δ
jupytext/languages.py 100.00% <ø> (ø)
tests/test_read_simple_groovy.py 100.00% <100.00%> (ø)
tests/test_read_simple_java.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f0f420...3d2dff7. Read the comment docs.

@mwouts
Copy link
Owner

mwouts commented Apr 27, 2020

Thank you @jest , that's awesome! I will be glad to ship this with the next release.

About this, I still have some work pending on 1.5.0, maybe for two more weeks. Don't you mind the delay? Otherwise I could backport your PR to 1.4.x as well. Let me know what you prefer. And thanks again!

@jest
Copy link
Author

jest commented Apr 28, 2020

Thanks!

I don't mind waiting; currently I install Jupytext with pip from git+https address pointing to my branch, so no hurry. :)

@mwouts mwouts added this to the 1.5.0 milestone Apr 29, 2020
@mwouts mwouts merged commit 5aa759c into mwouts:master Apr 29, 2020
@jest jest deleted the support-for-groovy-and-java branch April 29, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants