-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Load Error - content.indexOf is not a function when opening a text file in JupyterLab #659
Comments
Locally with JupyterLab 2.2.6 I don't reproduce the issue |
I'm finding the same with JupyterLab 2.2.9 and jupytext 1.7.0. Any ideas about what's happening? |
FWIW: Downgrading to jupytext 1.6.0 fixed the issue for me. |
Thank you @dfm for the input, that's very helpful. The major change between 1.6.0 and 1.7.0 is a refactoring of Jupytext's contents manager, I will have a look at it and see if I can identify any difference in how text notebooks are loaded between the two... |
Indeed, there is a slight difference in the model returned by the new contents manager, and that may be the cause of the issue. With Jupytext 1.7.0 the model for a text notebook is
while in Jupytext 1.6.0 that was
the difference is
That should be fairly easy to fix... |
@dfm, may I ask you to give a try to the proposed fix? I mean:
Thanks! |
The issue is gone on Binder. I will make a few more tests and distribute the new version later today if everything works fine. |
@mwouts: I can confirm that this fix works for me. Thanks! |
Excellent! Thank you for the confirmation. |
If I try to open a text notebook, say
World population.md
on , then I get this error:The version of JupyterLab used on Binder is 2.2.0.
The text was updated successfully, but these errors were encountered: