Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gnuplot support #998

Merged
merged 2 commits into from
Nov 12, 2022
Merged

Add gnuplot support #998

merged 2 commits into from
Nov 12, 2022

Conversation

razimantv
Copy link
Contributor

Added gnuplot support based on has2k1's gnuplot kernel.

The kernel supports % line magics. These are treated correctly when exporting to script and percent. But when exporting to hydrogen, the line magic remains as a line starting with % so that it is not a valid gnuplot line anymore. But I suppose that is how hydrogen works?

@mwouts
Copy link
Owner

mwouts commented Nov 10, 2022

Hi @razimantv , thank you so much for your PR! Sorry by the way for not responding before, I have been busy with a few other projects recently...

Yes the PR seems alright at first sight. And indeed the hydrogen format is the same as percent except that by default the magic commands are not commented out (because hydrogen executed the code with Jupyter, but I am not sure if that is still much used nowadays).

There are a few errors on the CI, and I think I have fixed them recently on main, would you like to rebase your PR on main ?

@razimantv
Copy link
Contributor Author

Sorry, a bit new to this. I merged the main branch, would this be enough?

@mwouts
Copy link
Owner

mwouts commented Nov 12, 2022

Yes it should work - let's see what the CI says!

@mwouts mwouts merged commit 418d67a into mwouts:main Nov 12, 2022
@mwouts
Copy link
Owner

mwouts commented Nov 12, 2022

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants