Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytests fail when using latest mxcubecore (v1.142.0) #1370

Closed
elmjag opened this issue Aug 27, 2024 · 2 comments
Closed

Pytests fail when using latest mxcubecore (v1.142.0) #1370

elmjag opened this issue Aug 27, 2024 · 2 comments

Comments

@elmjag
Copy link
Contributor

elmjag commented Aug 27, 2024

When running pytest, with latest mxcubecore (v1.142.0) installed, these tests fail:

FAILED test/test_beamline_routes.py::test_beamline_get_all_attribute - AssertionError: assert 31 == 30
FAILED test/test_beamline_routes.py::test_get_beam_info - AssertionError: assert False
FAILED test/test_diffractometer_routes.py::test_get_aperture - AssertionError: assert False
FAILED test/test_diffractometer_routes.py::test_set_aperture - AssertionError: assert 0.001 == 'A10'

I started looking into this, it seems these are changes related to resent beam definer changes.

I made an attempt to fix it: https://github.com/elmjag/mxcubeweb/tree/mocked-beam-definer but failed.

I'm trying to do two things on the branch above:

  • change mocked beamline to use the beam definer HWOBJs
  • update tests to work with API changes

I have trouble figuring out how it supposed to be. @beteva @meguiraun perhaps we can look at this together?

@elmjag elmjag changed the title Pytest fail when using latest mxcubecore (v1.142.0) Pytests fail when using latest mxcubecore (v1.142.0) Aug 27, 2024
@beteva
Copy link
Member

beteva commented Aug 27, 2024

Indeed I've changed the testst in mxcubecore, not in mxcubeweb. Mea culpa. Let me do the changes here and will come back to you.

@beteva
Copy link
Member

beteva commented Aug 28, 2024

@elmjag I've made two PRs - one in mxcubecore, another in mxcubeweb. They should solve the beam size/aperture problem you have 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants