-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytests fail when using latest mxcubecore (v1.142.0) #1370
Comments
This was referenced Aug 27, 2024
elmjag
changed the title
Pytest fail when using latest mxcubecore (v1.142.0)
Pytests fail when using latest mxcubecore (v1.142.0)
Aug 27, 2024
Indeed I've changed the testst in mxcubecore, not in mxcubeweb. Mea culpa. Let me do the changes here and will come back to you. |
Closed
This was referenced Aug 28, 2024
@elmjag I've made two PRs - one in mxcubecore, another in mxcubeweb. They should solve the beam size/aperture problem you have 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running pytest, with latest mxcubecore (v1.142.0) installed, these tests fail:
I started looking into this, it seems these are changes related to resent beam definer changes.
I made an attempt to fix it: https://github.com/elmjag/mxcubeweb/tree/mocked-beam-definer but failed.
I'm trying to do two things on the branch above:
I have trouble figuring out how it supposed to be. @beteva @meguiraun perhaps we can look at this together?
The text was updated successfully, but these errors were encountered: