Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boolean results with error handling #35

Open
logiad opened this issue Nov 6, 2014 · 1 comment
Open

Replace boolean results with error handling #35

logiad opened this issue Nov 6, 2014 · 1 comment
Labels
0 - Backlog
Milestone
1.1

Comments

@logiad
Copy link
Contributor

logiad commented Nov 6, 2014

Instead of returning a boolean, use errors to signify failure and res.end() for succes
Where no result is returned to frontend.
@logiad logiad self-assigned this Nov 6, 2014
@logiad logiad added this to the 1.0-beta milestone Nov 6, 2014
@mathieumg
Copy link
Member

Don't do it for tryLogin, I did it.

@mathieumg mathieumg modified the milestones: 1.0-beta, 1.0-rc1 Nov 13, 2014
@Cellule Cellule modified the milestones: 1.0, 1.0-rc Nov 18, 2014
@logiad logiad removed this from the 1.0 milestone Dec 8, 2014
@logiad logiad removed their assignment Dec 8, 2014
@mathieumg mathieumg added this to the 1.1 milestone Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
3 participants
@mathieumg @logiad @Cellule