Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False-positive when using mixed folder separator style (backslash and forward slash). #145

Open
vaillancourt opened this issue May 17, 2019 · 1 comment

Comments

@vaillancourt
Copy link

We have issues with false positives "bla/folder/src.cpp" should #include "bla/folder/src.h". This is due to us being on Windows, where we supply folders with backslashes (D:\dev\project\src\folder\), but we include files using forward slashes (#include "folder/file.h").

This can easily be fixed by wrapping every path that is imported into the tool with os.path.normpath.

This unfortunately breaks the tests on that line:

test/foo.h:221: unable to find 'dir//bar.h'

What's the intention behind using the double slashes here? Could we change the tests using a single slash instead?

@myint
Copy link
Owner

myint commented May 24, 2019

Your suggestion seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants