Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Support caching of revision identifiers #35

Open
myitcv opened this issue Nov 2, 2018 · 1 comment
Open

Support caching of revision identifiers #35

myitcv opened this issue Nov 2, 2018 · 1 comment

Comments

@myitcv
Copy link
Owner

myitcv commented Nov 2, 2018

Currently (well, once #32 is merged to be precise), gobin foo.com/bar@$revision will be the only form of gobin that always hit the network.

We can do better here by caching the resolution of these revision identifiers.

That way we unify the -u behaviour:

gobin foo.com/bar@master      # hits the network first time we need to resolve master
gobin foo.com/bar@master      # does not hit network
gobin -u foo.com/bar@master   # hits network

cc @rogpeppe

@myitcv
Copy link
Owner Author

myitcv commented Nov 3, 2018

To add a brief note; sufficient VCS information is not available in $GOPATH/pkg/mod/cache/vcs because each directory there is a shallow copy of the remote, hence it does not have any remote reference information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant