Fix incorrect error connecting to v4.1.1+ server (+ minor doc update) #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to connect to a v5.0 MySQL server (and possibly others) resulted in an oddly contradictory "Server doesn't support protocol v4.1 passwords" error.
Turns out, this was a bug based on a misinterpretation of the protocol spec (or perhaps an outdated version of the spec). Specifically, the low bit of the server capabilities does not refer to the new 4.1+ style passwords (as was previously thought), but rather a later version of the old-style passwords (rather conflusingly). The flag itself was deprecated in v4.1.1 and, according top the spec, should be assumed to be ON. See:
I also snuck in a few minor documentation updates: