forked from simendsjo/mysqln
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Prepared (Fixes #95, #97) #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/query overloads.
…teRegister functions.
…ed, and indexed by sql string.
…ing, and to operate on sql strings, not ids.
…n compiling unittests).
Abscissa
changed the title
[WIP] Redesign Prepared (Fixes #95)
[WIP] Redesign Prepared (Fixes #95, #97)
Feb 3, 2018
…y failing to update parts of it.
…efcounted during GC cycle.
…repared statement.
Abscissa
changed the title
[WIP] Redesign Prepared (Fixes #95, #97)
Redesign Prepared (Fixes #95, #97)
Feb 4, 2018
Just waiting for travis-ci approval now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to fix #95. It should also improve reliability as it also fixes #97.
Full description, including motivation, is in the included file ABOUT_PREPARED_V2.md
Tasks:
PreparedImpl
.Prepared.exec
/Prepared.query
. (Make them overloads of the regularexec
/query
functions.)Prepared.release
/Prepared.register
.Prepared
's reference to aConnection
.mysql.prepared
's dependency onmysql.connection
(except when compiling unittests).Connection
manages a list of the prepared statements registered on it.Connection.release
/Connection.register
functionality.Connection.release
/Connection.register
.Create public(delayed for follow-up release).ConnectionPool.release
/ConnectionPool.register
Prepared
the first time it's used on aConnection
(if not already manually registered).prepareBackwardCompat
.Test calling release during GC cycle.(blocked by Solve the prepared statement automatic-release difficulty #159)Implement Convenience exec/query overloads that do parameterized SQL #118(delayed for follow-up release).