-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata tests on MariaDB 10.2 and 10.3 #186
Comments
Possibly a result of #90? |
This may be why my code is breaking on Fedora 28 (mariadb 10.2.14): Query q = session.createQuery("FROM MyThing ORDER BY created DESC");
auto things = q.list!MyThing(); // <-- dies here if this is due to the related issue, any idea on when a new release will be available? |
Hard to say at the moment. I was really hoping to be able to do my long-awaited internal cleanup of the low-level protocol-handling code before anything else relating to that code. But under the circumstances, I don't think I have that luxury. This is too critical-priority. In any case, I won't have a good idea how involved this will be until I'm actually knee-deep into #90, which I'm going to need to tackle ASAP (probably right after I finish the already-in-progress #65). I'll post updates as I know more. What I can say though, is that once this is fixed, that will justify an immediate new release. |
Ugh, something weird going on with this. I haven't even touched the relevant parts of the code, but now travis is showing no problem at all with the code quoted above, but instead there's a failure here. The good news is most of the tests actually seem to be running fine. Suspecting #90 may not be related after all. |
Ok, looks like this is considerably less serious than I thought, and probably isn't the issue you're hitting unless you're relying on the metadata module. Turns out, I originally misread the line number of the assert failure (ie, line 473, not 173) The assert failure was ALWAYS this one, not the one quoted in my original post. The true issue is that on MariaDB 10.2+ On the table used in the tests, the columns are nullable and default to null. But for some reason, on MariaDB 10.2+, instead of getting the normal...
...it's getting...
...instead. Which is indeed weird...but should be benign in most cases. All the other null-related tests (and in fact, all the other tests period) pass successfully on MariaDB 10.2 and 10.3. |
Aha: From https://mariadb.com/kb/en/library/information-schema-columns-table/
So that explains it. |
Travis-ci reports assert failure on
the last line in this excerpt fromwhen using MariaDB 10.2 (travis is using 10.2.14) and up:source/mysql/test/integration.d
EDIT: It is NOT this code after all:
EDIT: Apparently I read the line number wrong. The above line was never the test failure. This line is where the test failure was.
The text was updated successfully, but these errors were encountered: