Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow limiting number of connections in connection pool #74

Closed
schveiguy opened this issue Jun 27, 2016 · 1 comment
Closed

Allow limiting number of connections in connection pool #74

schveiguy opened this issue Jun 27, 2016 · 1 comment
Labels

Comments

@schveiguy
Copy link
Collaborator

In MysqlDB, the vibe.d ConnectionPool type is used to manage connections.

However, the limit on the number of connections is unspecified, and defaults to uint.max.

What is the point of using connection pool if you aren't going to limit connections? I thought that was the entire point. If you don't limit, and don't close connections you are done with, you run the risk of having tens of thousands of connections open to the DB. So you need to close the connections after use. But then, you are simply saving the cost of allocation/deallocation, which isn't very much (and replacing it with a linear search through the connection pool + hash lookups when allocating a new one).

@Abscissa Abscissa added the api label Oct 20, 2016
@Abscissa
Copy link

Abscissa commented Mar 1, 2017

Fixed in v1.0.0

@Abscissa Abscissa closed this as completed Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants