Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear Connection.getNextRow is internal, not public #96

Closed
Abscissa opened this issue Mar 1, 2017 · 2 comments
Closed

Make it clear Connection.getNextRow is internal, not public #96

Abscissa opened this issue Mar 1, 2017 · 2 comments
Labels
api breaking docs
Milestone
v2.0.0

Comments

@Abscissa
Copy link

Abscissa commented Mar 1, 2017

Change it from public to package if possible. In any case, need to update it's documentation.

Also, improve the doc comment for Connection.rowsPending while I'm at it.
@Abscissa Abscissa added the docs label Mar 1, 2017
@Abscissa Abscissa mentioned this issue Mar 1, 2017
Closed
@Abscissa Abscissa added this to the v2.0.0 milestone Feb 4, 2018
@Abscissa
Copy link
Author

Abscissa commented Feb 4, 2018

The docs have been describing this as "Internal, avoid using" for awhile now. Going to remove public access for v2.0.0.

@Abscissa
Copy link
Author

Abscissa commented Feb 4, 2018

Closed by 0eefe8f

@Abscissa Abscissa closed this as completed Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api breaking docs
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@Abscissa