Get ownerDocument before calling onStop handlers

[acusti]

If a draggable onStop handler (invoked in DraggableCore:318) causes the wrapped component to unmount, calling ReactDOM.findDOMNode in line 321 will error with Uncaught Invariant Violation: findDOMNode was called on an unmounted component.

Using findDOMNode before calling onStop avoids that bug and prevents having to also invoke it for the userSelect hack. A win-win.

[STRML]

👍 Nice fix.

[bkniffler]

Could you please publish this to npm? Thanks!

[acusti]

@bkniffler If you want an installable version with this fix, you can temporarily use:
"react-draggable": "Brandcast/react-draggable#1de1e66",

in your package.json until this gets published. The #1de1e66 hash just points to my commit of the built files.

[STRML]

This is published as v2.2.2.

Andrew Patton mailto:[email protected]
September 14, 2016 at 11:31 AM

@bkniffler https://github.com/bkniffler If you just want an
installable version with this fix, you can temporarily use:
|"react-draggable": "Brandcast/react-draggable#1de1e66",|

in your package.json until this gets published.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#198 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJFP10oJE8alFxnXW5eG_r5XcdEEg-8ks5qqCFTgaJpZM4J2g9Q.

Andrew Patton mailto:[email protected]
September 6, 2016 at 11:06 PM

If a draggable |onStop| handler (invoked in DraggableCore:318
https://github.com/mzabriskie/react-draggable/blob/master/lib/DraggableCore.es6#L318)
causes the wrapped component to unmount, calling
|ReactDOM.findDOMNode| in line 321
https://github.com/mzabriskie/react-draggable/blob/master/lib/DraggableCore.es6#L321
will error with |Uncaught Invariant Violation: findDOMNode was called
on an unmounted component|.

Using findDOMNode before calling |onStop| avoids that bug and prevents
having to also invoke it for the userSelect hack. A win-win.

---

    You can view, comment on, or merge this pull request online at:

#198

    Commit Summary

• Get ownerDocument before calling onStop handlers

  File Changes
  

• M lib/DraggableCore.es6
  https://github.com/mzabriskie/react-draggable/pull/198/files#diff-0
  (4)

  Patch Links:
  

• https://github.com/mzabriskie/react-draggable/pull/198.patch

• https://github.com/mzabriskie/react-draggable/pull/198.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#198, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABJFP7DwQQsbZGGgXiBdxDkWr8FVOvA0ks5qnjhPgaJpZM4J2g9Q.