fix: parse and stringify data in serializers (#358)

mzgoddard · May 30, 2018 · c40fd30 · c40fd30
1 parent f01d8ba
commit c40fd30
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/lib/CacheEnhancedResolve.js b/lib/CacheEnhancedResolve.js
@@ -28,11 +28,13 @@ class EnhancedResolveCache {
         missingCacheSerializer = cacheSerializerFactory.create({
           name: 'missing-resolve',
           type: 'data',
+          autoParse: true,
           cacheDirPath,
         });
         resolverCacheSerializer = cacheSerializerFactory.create({
           name: 'resolver',
           type: 'data',
+          autoParse: true,
           cacheDirPath,
         });
       },

diff --git a/lib/CacheMd5.js b/lib/CacheMd5.js
@@ -178,6 +178,7 @@ class Md5Cache {
         md5CacheSerializer = cacheSerializerFactory.create({
           name: 'md5',
           type: 'data',
+          autoParse: true,
           cacheDirPath,
         });
       },
@@ -371,7 +372,7 @@ class Md5Cache {
 
                 md5Ops.push({
                   key: relateNormalPath(compiler, file),
-                  value: JSON.stringify(value),
+                  value: value,
                 });
               } else if (
                 !value.mtime &&
@@ -463,7 +464,7 @@ class Md5Cache {
             for (const key in unbuildMd5s) {
               md5Ops.push({
                 key: relateNormalPath(compiler, key),
-                value: JSON.stringify(unbuildMd5s[key]),
+                value: unbuildMd5s[key],
               });
             }
           }

diff --git a/lib/CacheModuleResolver.js b/lib/CacheModuleResolver.js
@@ -22,6 +22,7 @@ class ModuleResolverCache {
         moduleResolveCacheSerializer = cacheSerializerFactory.create({
           name: 'module-resolve',
           type: 'data',
+          autoParse: true,
           cacheDirPath,
         });
       },
@@ -287,12 +288,7 @@ class ModuleResolverCache {
             moduleResolveOps.push({
               key: relateNormalModuleResolveKey(compiler, key),
               value: moduleResolveCache[key]
-                ? JSON.stringify(
-                    relateNormalModuleResolve(
-                      compiler,
-                      moduleResolveCache[key],
-                    ),
-                  )
+                ? relateNormalModuleResolve(compiler, moduleResolveCache[key])
                 : null,
             });
           });