Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude mini-css loader modules #382

Merged
merged 5 commits into from
Jun 14, 2018
Merged

fix: exclude mini-css loader modules #382

merged 5 commits into from
Jun 14, 2018

Conversation

mzgoddard
Copy link
Owner

@mzgoddard mzgoddard commented Jun 14, 2018

Fix #357
Fix #367
Fix #378

mini-css does not emit assets when built from webpack's memory cache or hard-source's disk cache. Exclude the modules that lead to the child compilations that emit the assets so the assets are always emitted. This has a minor performance change instead of a large performance hit because the bulk of the css work is still cached outside of these excluded modules.

mini-css does not emit assets when built from webpack's memory cache or
hard-source's disk cache. Exclude the modules that lead to the child
compilations that emit the assets so the assets are always emitted.
This has a minor performance change instead of a large performance hit
because the bulk of the css work is still cached outside of these
excluded modules.
@mzgoddard mzgoddard merged commit 1c8eb1f into master Jun 14, 2018
@mzgoddard mzgoddard deleted the exclude-mini-css branch June 14, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant