Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak in TransformNormalModuleFactoryPlugin #414

Merged
merged 1 commit into from
Jul 30, 2018
Merged

fix: memory leak in TransformNormalModuleFactoryPlugin #414

merged 1 commit into from
Jul 30, 2018

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Jul 27, 2018

Problem: plugin wraps createLoaderContext without checking if it was
already done before. As a result, in a watch mode more and more wrappers
get added on top of the function and eat more and more memory. Fixed by
saving original function on module instance itself and wrapping saved
function instead.

Fixes #409

Problem: plugin wraps createLoaderContext without checking if it was
already done before. As a result, in a watch mode more and more wrappers
get added on top of the function and eat more and more memory. Fixed by
saving original function on module instance itself and wrapping saved
function instead.
@SevInf
Copy link
Contributor Author

SevInf commented Jul 30, 2018

@mzgoddard I'm pretty sure failing tests are just flaky. There were two builds on travis (first and second) and different tests fail. The only difference between those two builds is formatting.

@mzgoddard
Copy link
Owner

@SevInf thank you for finding this.

I'm increasing the timeout again in another PR for all tests since travis isn't reliable testing full webpack builds.

@mzgoddard mzgoddard merged commit 33b306b into mzgoddard:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants