-
Notifications
You must be signed in to change notification settings - Fork 15
Use CIDv1 for all dags constructed by iroh, output string representations in base32 CIDv1 #137
Comments
We currently use CIDv1 when building our DAGs, but accept reading DAGs from both versions! |
cool, so this should just be a matter of changing the output format in the |
I'm not sure what you mean by that, when you add content using Is there a specific place you've seen CIDv0 that I'm missing? |
nope. just wanted to confirm this direction & get it on the record. All good! |
Are you also enabling raw-leaves when using CIDv1 during UnixFS dag creation? fysa Kubo (go-ipfs ~0.4) made a decision to make it default for CIDv1 to enables raw leaves.
iirc https://github.com/ipfs/go-unixfs still produces CIDv0 by default, but if we ever change it toproduce CIDv1, it may also mean enabling raw leaves and changing DAG multihashes. |
A lot of our code is using Base58 CIDv0 (the CIDs that start with
Qm
). We need to use base32 CIDv1 everywhere (the longer, more annoying looking ones likebafybeieoxkt2hpo26ulnpldsopqmrjsi4iewa53v5slmqejkc4qfbycxpy
).This is only applies to CIDs Iroh constructs. Read operations like
iroh get
still need to accept & return CIDv0 format when requested.The CID Inspector is a super useful tool for understanding the format.
We're not massive fans of the UX hit that base32 gives, but we need to be able to copypasta into URL bars, and this is the only modern format that works for such a thing.
Landing this in time for our first release is going to be painful, but let's keep in mind, changing this sort of thing can take years, and even then not fully land.
The text was updated successfully, but these errors were encountered: