Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

service "version" unification #39

Open
ramfox opened this issue Dec 17, 2022 · 1 comment
Open

service "version" unification #39

ramfox opened this issue Dec 17, 2022 · 1 comment

Comments

@ramfox
Copy link
Contributor

ramfox commented Dec 17, 2022

Right the version and watch RPC calls use the version information pulled in from env!("CARGO_PKG_VERSION").
Our metrics, also track the "build version" using git_version.
What do we want to show to folks when they ask for a "version"? This is primarily seen in the iroh status -w CLI call
@fabricedesre
Copy link
Contributor

I like what rustc does:

$ rustc --version
rustc 1.66.0 (69f9c33d7 2022-12-12)

@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
@ramfox ramfox removed this from iroh Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabricedesre @ramfox