Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

make sure docker compose example doesn't expose writeable APIs #72

Closed
b5 opened this issue Nov 18, 2022 · 0 comments · Fixed by n0-computer/iroh#524
Closed

make sure docker compose example doesn't expose writeable APIs #72

b5 opened this issue Nov 18, 2022 · 0 comments · Fixed by n0-computer/iroh#524
Assignees
@b5

Comments

@b5
Copy link
Member

b5 commented Nov 18, 2022

We don't want default docker compose files to expose internal or writable APIs, sets a bad example for others building off this compose file as an example setup. See: #84

Instead, example docker compose file should listen on loopback. Example of the technique:
https://github.com/ipfs/kubo/blob/039badf3b24bba4b3a6ca80e2b5163afa4e4b7cb/docker-compose.yaml#L1
@b5 b5 self-assigned this Nov 18, 2022
b5 referenced this issue in n0-computer/iroh Nov 18, 2022
@b5
fix: docker-compose RPC ports should only listen on loopback
a0f16d6 
closes #520
@b5 b5 mentioned this issue Nov 18, 2022
Merged
b5 referenced this issue in n0-computer/iroh Nov 19, 2022
@b5
fix: docker-compose RPC ports should only listen on loopback (#524)
8471e49 
* fix: docker-compose RPC ports should only listen on loopback

closes #520
@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
@ramfox ramfox removed this from iroh Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@b5 b5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: docker-compose RPC ports should only listen on loopback n0-computer/iroh
1 participant
@b5